Update all deeptools conda environment YAML files to version 3.5.6#9685
Update all deeptools conda environment YAML files to version 3.5.6#9685bentyeh wants to merge 2 commits intonf-core:masterfrom
Conversation
Updating to version 3.5.6 bypasses a previous bug where deeptools version 3.5.5 is not compatible with NumPy version 2, but the bioconda recipe (meta.yaml; https://github.com/bioconda/bioconda-recipes/blob/591f3c411db2cb334511f0f13e60b4d4d9cadb2f/recipes/deeptools/meta.yaml) for deeptools version 3.5.5 only specifies a lower limit on NumPy versions (numpy >=1.9.0), which inadvertently allows conda to install NumPy version 2 and deeptools version 3.5.5 in the same environment, leading to incompatibilities and pipeline errors.
SPPearce
left a comment
There was a problem hiding this comment.
You'll need to also update the containers specified in the main.nf files, and rerun the tests to update the snapshots.
If you are able to, it'd be helpful to also swap to using topic channels: https://nf-co.re/docs/tutorials/migrate_to_topics/update_modules
|
@SPPearce Thank you for the comment. I'm new to nextflow and also not familiar with maintaining/updating containers. Would you mind pointing me to resources/tutorials about how to update the containers? |
|
In the main.nf for each module, the containers for docker and singularity are defined: These will need to be updated to the 3.5.6 version. |
|
Closing in favour of #10037 10037 |
Updating to version 3.5.6 bypasses a previous bug where deeptools version 3.5.5 is not compatible with NumPy version 2, but the bioconda recipe (meta.yaml; https://github.com/bioconda/bioconda-recipes/blob/591f3c411db2cb334511f0f13e60b4d4d9cadb2f/recipes/deeptools/meta.yaml) for deeptools version 3.5.5 only specifies a lower limit on NumPy versions (numpy >=1.9.0), which inadvertently allows conda to install NumPy version 2 and deeptools version 3.5.5 in the same environment, leading to incompatibilities and pipeline errors.
PR checklist
Closes #XXX
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda