Skip to content

deeptools 3.5.6 update and snapshots#10037

Merged
SPPearce merged 4 commits intonf-core:masterfrom
pauldrinn:master
Feb 18, 2026
Merged

deeptools 3.5.6 update and snapshots#10037
SPPearce merged 4 commits intonf-core:masterfrom
pauldrinn:master

Conversation

@pauldrinn
Copy link
Contributor

@pauldrinn pauldrinn commented Feb 16, 2026

Also completes #9685. Tested on different machines with docker, singularity and conda.

PR checklist

  • This comment contains a description of changes (with reason).
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda

Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine to go.
It would be helpful if the modules were swapped to use the topic channel for the version output, the details are here: https://nf-co.re/docs/tutorials/migrate_to_topics/update_modules if you are able to spend some time doing that.

@pauldrinn
Copy link
Contributor Author

Yes I can implement that as well

@pauldrinn
Copy link
Contributor Author

pauldrinn commented Feb 17, 2026

@SPPearce changed all to use topic channels, thanks for the info!

Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for being willing to do this too!
Some comments on simplifying the version extraction, they apply to all tools. I know you just copied the previous version command, but taking the opportunity to simplify a bit as we go through.

Also you should go to the nf-core slack and post on #github-invitations to be added to the organisation, then the tests would run automatically.

@pauldrinn
Copy link
Contributor Author

Thank you for being willing to do this too! Some comments on simplifying the version extraction, they apply to all tools. I know you just copied the previous version command, but taking the opportunity to simplify a bit as we go through.

Also you should go to the nf-core slack and post on #github-invitations to be added to the organisation, then the tests would run automatically.

Thanks for the help! I edited everything and posted on slack to be a part of the organization. Testing now so will push one more commit.

Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@SPPearce SPPearce enabled auto-merge February 18, 2026 09:38
@SPPearce SPPearce added this pull request to the merge queue Feb 18, 2026
Merged via the queue into nf-core:master with commit b985685 Feb 18, 2026
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants