deeptools 3.5.6 update and snapshots#10037
Conversation
SPPearce
left a comment
There was a problem hiding this comment.
This is fine to go.
It would be helpful if the modules were swapped to use the topic channel for the version output, the details are here: https://nf-co.re/docs/tutorials/migrate_to_topics/update_modules if you are able to spend some time doing that.
|
Yes I can implement that as well |
|
@SPPearce changed all to use topic channels, thanks for the info! |
SPPearce
left a comment
There was a problem hiding this comment.
Thank you for being willing to do this too!
Some comments on simplifying the version extraction, they apply to all tools. I know you just copied the previous version command, but taking the opportunity to simplify a bit as we go through.
Also you should go to the nf-core slack and post on #github-invitations to be added to the organisation, then the tests would run automatically.
Thanks for the help! I edited everything and posted on slack to be a part of the organization. Testing now so will push one more commit. |
Also completes #9685. Tested on different machines with docker, singularity and conda.
PR checklist
nf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile conda