Skip to content

chain 0.23.x: Fix panic in scan loop and update msrv and esplora-client#2148

Merged
oleonardolima merged 4 commits intobitcoindevkit:release/chain-0.23.xfrom
evanlinjin:feature/chain-0.23.x-esplora
Mar 11, 2026
Merged

chain 0.23.x: Fix panic in scan loop and update msrv and esplora-client#2148
oleonardolima merged 4 commits intobitcoindevkit:release/chain-0.23.xfrom
evanlinjin:feature/chain-0.23.x-esplora

Conversation

@evanlinjin
Copy link
Member

@evanlinjin evanlinjin commented Mar 11, 2026 •
edited
Loading

Description

Backport of #2053, #2136. Also fixes CI MSRV issues.

Replaces #2147 - Purely MSRV fixes still resulted in CI failure due to clippy.
Replaces #2141 - Might as well include the whole PR backport.

Changelog notice

Fixed:
- Avoid a panic in the Esplora stop‑gap scan loop by tracking consecutive unused scripts to compute the gap boundary.
- Bump `esplora_client` to `0.12.3` so that the `.get_block_infos` method is always available.

Checklists

All Submissions:

@evanlinjin evanlinjin self-assigned this Mar 11, 2026
@evanlinjin evanlinjin added this to the Chain 0.23.3 milestone Mar 11, 2026
@evanlinjin evanlinjin changed the title Fix panic in scan loop and update msrv and esplora-client chain 0.23.x: Fix panic in scan loop and update msrv and esplora-client Mar 11, 2026
@evanlinjin evanlinjin mentioned this pull request Mar 11, 2026
Closed
1 task
@evanlinjin evanlinjin marked this pull request as ready for review March 11, 2026 11:04
@evanlinjin evanlinjin moved this to Needs Review in BDK Chain Mar 11, 2026
@evanlinjin
Copy link
Member Author

evanlinjin commented Mar 11, 2026

Code coverage is borked. Can merge without imo.

This was referenced Mar 11, 2026
Closed
Open
luisschwab
luisschwab approved these changes Mar 11, 2026
View reviewed changes
Copy link
Member

@luisschwab luisschwab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2ee48d7

This was referenced Mar 11, 2026
Open
Open
@oleonardolima oleonardolima added the backport A bug fix or security patch to be ported to a previous release label Mar 11, 2026
oleonardolima
oleonardolima approved these changes Mar 11, 2026
View reviewed changes
Copy link
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2ee48d7

@oleonardolima oleonardolima merged commit d8be40c into bitcoindevkit:release/chain-0.23.x Mar 11, 2026
17 of 19 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Chain Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oleonardolima oleonardolima oleonardolima approved these changes

@luisschwab luisschwab luisschwab approved these changes

Assignees

@evanlinjin evanlinjin

Labels

backport A bug fix or security patch to be ported to a previous release

Projects

BDK Chain
Status: Done

Milestone

Chain 0.23.3

Development

Successfully merging this pull request may close these issues.

4 participants

@evanlinjin @oleonardolima @luisschwab @reez