Skip to content

bdk_chain v0.23.x: Fix pin MSRV#2147

Closed
evanlinjin wants to merge 2 commits intobitcoindevkit:release/chain-0.23.xfrom
evanlinjin:feature/chain-0.23.x-pin-msrv
Closed

bdk_chain v0.23.x: Fix pin MSRV#2147
evanlinjin wants to merge 2 commits intobitcoindevkit:release/chain-0.23.xfrom
evanlinjin:feature/chain-0.23.x-pin-msrv

Conversation

@evanlinjin
Copy link
Member

@evanlinjin evanlinjin commented Mar 11, 2026

Description

Fix pinning MSRV for both 1.63.0 and 1.75.0.

Checklists

All Submissions:

@evanlinjin evanlinjin changed the title ci: Fix ci/pin-msrv.sh 0.23.x: Fix ci/pin-msrv.sh Mar 11, 2026
@evanlinjin evanlinjin changed the title 0.23.x: Fix ci/pin-msrv.sh bdk_chain v0.23.x: Fix ci/pin-msrv.sh Mar 11, 2026
@evanlinjin
Copy link
Member Author

Okay pin MSRV for 1.75 is also borked. Need to fix.

@evanlinjin evanlinjin force-pushed the feature/chain-0.23.x-pin-msrv branch from f766b75 to fecf431 Compare March 11, 2026 10:52
@evanlinjin evanlinjin changed the title bdk_chain v0.23.x: Fix ci/pin-msrv.sh bdk_chain v0.23.x: Fix pin MSRV Mar 11, 2026
@evanlinjin evanlinjin self-assigned this Mar 11, 2026
@evanlinjin evanlinjin added this to the Chain 0.23.3 milestone Mar 11, 2026
@evanlinjin
Copy link
Member Author

Closed in favor of #2148

@evanlinjin evanlinjin closed this Mar 11, 2026
oleonardolima added a commit that referenced this pull request Mar 11, 2026
…nd esplora-client

2ee48d7 fix(esplora): Bump `esplora-client` to `0.12.3` (志宇)
af6791f ci: Fix `ci/pin-msrv.sh` (志宇)
fb3e169 ci: Fix pin msrv for 1.75.0 (志宇)
8d2ca9b fix: remove panic from stop gap scan loop (Matthew)

Pull request description:

  ### Description

  Backport of #2053, #2136. Also fixes CI MSRV issues.

  Replaces #2147 - Purely MSRV fixes still resulted in CI failure due to clippy.
  Replaces #2141 - Might as well include the whole PR backport.

  ### Changelog notice

  ```md
  Fixed:
  - Avoid a panic in the Esplora stop‑gap scan loop by tracking consecutive unused scripts to compute the gap boundary.
  - Bump `esplora_client` to `0.12.3` so that the `.get_block_infos` method is always available.
  ```

  ### Checklists

  #### All Submissions:

  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)

ACKs for top commit:
  luisschwab:
    ACK 2ee48d7
  oleonardolima:
    ACK 2ee48d7

Tree-SHA512: 0f183e2b5ffc6629298f960f22e95020df58da98171c69e880afab5d57f337af240ff7ad97244f3f052d3b1a3fdd8a91543b5a943eeac2234de02672fc94d3f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant