Skip to content

fix(bdk_esplora): use get_blocks_infos instead of get_blocks#2141

Closed
oleonardolima wants to merge 1 commit intobitcoindevkit:release/chain-0.23.xfrom
oleonardolima:deps/bump-esplora-client-and-fix-warnings
Closed

fix(bdk_esplora): use get_blocks_infos instead of get_blocks#2141
oleonardolima wants to merge 1 commit intobitcoindevkit:release/chain-0.23.xfrom
oleonardolima:deps/bump-esplora-client-and-fix-warnings

Conversation

@oleonardolima
Copy link
Collaborator

Description

It's basically a backport of #2130. It bumps the esplora-client version, and replaces the usage of deprecated get_blocks.

Changelog notice

### Changed

- deps(esplora-client): bump to `v0.12.3`.
- fix(bdk_esplora): use `get_block_infos` instead of `get_blocks`.

Checklists

All Submissions:

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

- bumps the `esplora-client` to `v0.12.3`.
- use new `get_block_infos` instead of deprecated `get_blocks`.
@oleonardolima oleonardolima added this to the Chain 0.23.3 milestone Mar 9, 2026
@oleonardolima oleonardolima requested a review from evanlinjin March 9, 2026 19:00
@oleonardolima oleonardolima self-assigned this Mar 9, 2026
@oleonardolima oleonardolima added the dependencies Pull requests that update a dependency file label Mar 9, 2026
@oleonardolima
Copy link
Collaborator Author

Oh, forgot how old MSRV was annoying, need to pin some deps.

@luisschwab luisschwab self-requested a review March 9, 2026 23:50
@notmandatory notmandatory moved this to Discussion in BDK Chain Mar 10, 2026
@evanlinjin
Copy link
Member

Why don't we just include all changes from #2053?

@evanlinjin
Copy link
Member

I advice replacing this with #2148

@luisschwab
Copy link
Member

Closing in favor of #2148

@luisschwab luisschwab closed this Mar 11, 2026
@github-project-automation github-project-automation bot moved this from Discussion to Done in BDK Chain Mar 11, 2026
oleonardolima added a commit that referenced this pull request Mar 11, 2026
…nd esplora-client

2ee48d7 fix(esplora): Bump `esplora-client` to `0.12.3` (志宇)
af6791f ci: Fix `ci/pin-msrv.sh` (志宇)
fb3e169 ci: Fix pin msrv for 1.75.0 (志宇)
8d2ca9b fix: remove panic from stop gap scan loop (Matthew)

Pull request description:

  ### Description

  Backport of #2053, #2136. Also fixes CI MSRV issues.

  Replaces #2147 - Purely MSRV fixes still resulted in CI failure due to clippy.
  Replaces #2141 - Might as well include the whole PR backport.

  ### Changelog notice

  ```md
  Fixed:
  - Avoid a panic in the Esplora stop‑gap scan loop by tracking consecutive unused scripts to compute the gap boundary.
  - Bump `esplora_client` to `0.12.3` so that the `.get_block_infos` method is always available.
  ```

  ### Checklists

  #### All Submissions:

  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)

ACKs for top commit:
  luisschwab:
    ACK 2ee48d7
  oleonardolima:
    ACK 2ee48d7

Tree-SHA512: 0f183e2b5ffc6629298f960f22e95020df58da98171c69e880afab5d57f337af240ff7ad97244f3f052d3b1a3fdd8a91543b5a943eeac2234de02672fc94d3f2
@oleonardolima oleonardolima deleted the deps/bump-esplora-client-and-fix-warnings branch March 11, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants