Skip to content

chore: Add Integer Annotation Type#1758

Merged
camielvs merged 1 commit intomasterfrom
02-05-chore_add_integer_annotation_type
Mar 5, 2026
Merged

chore: Add Integer Annotation Type#1758
camielvs merged 1 commit intomasterfrom
02-05-chore_add_integer_annotation_type

Conversation

@camielvs
Copy link
Collaborator

@camielvs camielvs commented Feb 5, 2026

Description

Adds integer as a supported annotation value type. An integer annotation will render as a numeric input, the same as number, but disallows the input of decimal values.

Enables us to add zIndex editing to Tasks and IO Nodes via annotations.

Related Issue and Pull requests

Type of Change

  • Improvement

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

  • Add a new common annotation to the launcherTaskAnnotationSchema.json with type integer. Hard-restart the dev server (hmr won't pick up on static json changes).
  • Go to a task. You should see your new annotation in the config panel.
  • Confirm that it does not allow decimal input, including via copy and paste

Additional Comments

Copy link
Collaborator Author

camielvs commented Feb 5, 2026

@camielvs camielvs force-pushed the 02-05-chore_add_integer_annotation_type branch from 72b3649 to f9add7a Compare February 5, 2026 19:35
@camielvs camielvs force-pushed the 02-05-chore_add_integer_annotation_type branch from f9add7a to d9a6362 Compare February 5, 2026 21:42
@camielvs camielvs force-pushed the 02-04-feat_add_zindex_management_for_all_nodes branch from 47ed74b to 017eef0 Compare February 5, 2026 21:42
@camielvs camielvs force-pushed the 02-05-chore_add_integer_annotation_type branch from d9a6362 to f5ada4a Compare February 5, 2026 22:36
@camielvs camielvs force-pushed the 02-04-feat_add_zindex_management_for_all_nodes branch from 017eef0 to ae5afd2 Compare February 5, 2026 22:36
@camielvs camielvs force-pushed the 02-05-chore_add_integer_annotation_type branch from f5ada4a to 93ff57d Compare February 6, 2026 16:07
@camielvs camielvs force-pushed the 02-04-feat_add_zindex_management_for_all_nodes branch 2 times, most recently from 12359db to 6dff3a1 Compare February 6, 2026 19:43
@camielvs camielvs force-pushed the 02-05-chore_add_integer_annotation_type branch from 93ff57d to 47c9447 Compare February 6, 2026 19:43
@camielvs camielvs force-pushed the 02-04-feat_add_zindex_management_for_all_nodes branch from 6dff3a1 to ce36983 Compare February 6, 2026 19:49
@camielvs camielvs force-pushed the 02-05-chore_add_integer_annotation_type branch 2 times, most recently from 93c408b to 8a14810 Compare February 6, 2026 22:19
@camielvs camielvs force-pushed the 02-05-chore_add_integer_annotation_type branch from c6d3736 to 2524193 Compare February 19, 2026 00:23
@camielvs camielvs force-pushed the 02-04-feat_add_zindex_management_for_all_nodes branch from 7e1e9cd to 350000b Compare February 19, 2026 00:23
@camielvs camielvs mentioned this pull request Feb 19, 2026
3 tasks
@camielvs camielvs force-pushed the 02-04-feat_add_zindex_management_for_all_nodes branch from 350000b to ac6e50b Compare February 19, 2026 17:59
@camielvs camielvs force-pushed the 02-05-chore_add_integer_annotation_type branch from 2524193 to 6131e1e Compare February 19, 2026 17:59
@camielvs camielvs changed the base branch from 02-04-feat_add_zindex_management_for_all_nodes to graphite-base/1758 February 19, 2026 19:53
@camielvs camielvs force-pushed the 02-05-chore_add_integer_annotation_type branch from 6131e1e to 3cbea70 Compare February 19, 2026 20:04
@camielvs camielvs changed the base branch from graphite-base/1758 to 02-04-feat_add_zindex_management_for_all_nodes February 19, 2026 20:04
@camielvs camielvs force-pushed the 02-04-feat_add_zindex_management_for_all_nodes branch from 25650b0 to e36e164 Compare February 19, 2026 20:07
@camielvs camielvs force-pushed the 02-05-chore_add_integer_annotation_type branch from 3cbea70 to 1edc40c Compare February 19, 2026 20:07
@camielvs camielvs changed the base branch from 02-04-feat_add_zindex_management_for_all_nodes to graphite-base/1758 February 19, 2026 20:10
@camielvs camielvs force-pushed the 02-05-chore_add_integer_annotation_type branch from 1edc40c to ebad0ac Compare February 19, 2026 23:00
@camielvs camielvs changed the base branch from graphite-base/1758 to master February 19, 2026 23:00
@camielvs camielvs force-pushed the 02-05-chore_add_integer_annotation_type branch from ebad0ac to 321266f Compare March 2, 2026 21:48
@github-actions
Copy link

github-actions bot commented Mar 2, 2026

🎩 To tophat this PR:

You can add the following URL parameter to your browser to tophat this PR:

`?tophat_location=02-05-chore_add_integer_annotation_type/fab0cbb`

@camielvs camielvs force-pushed the 02-05-chore_add_integer_annotation_type branch from 321266f to 101a28f Compare March 3, 2026 00:13
Copy link

@morgan-wowk morgan-wowk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The useCallback feedback from Graphite looks sound

@camielvs camielvs force-pushed the 02-05-chore_add_integer_annotation_type branch 2 times, most recently from 5c7401b to 0ea6fa9 Compare March 5, 2026 21:25
Copy link
Collaborator Author

camielvs commented Mar 5, 2026

Merge activity

  • Mar 5, 9:29 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 5, 9:30 PM UTC: Graphite rebased this pull request as part of a merge.
  • Mar 5, 9:31 PM UTC: @camielvs merged this pull request with Graphite.

@camielvs camielvs force-pushed the 02-05-chore_add_integer_annotation_type branch from 0ea6fa9 to fab0cbb Compare March 5, 2026 21:29
@camielvs camielvs merged commit 2025013 into master Mar 5, 2026
17 checks passed
@camielvs camielvs deleted the 02-05-chore_add_integer_annotation_type branch March 5, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants