feat: zIndex Management for Task Nodes#1757
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
f61141b to
8a478b7
Compare
8a478b7 to
c39283b
Compare
72b3649 to
f9add7a
Compare
1d06dfb to
fcd9564
Compare
fcd9564 to
5026c52
Compare
f9add7a to
d9a6362
Compare
5026c52 to
ee6ff89
Compare
9b3b118 to
c6d3736
Compare
69a9e3f to
28aaa39
Compare
c6d3736 to
2524193
Compare
28aaa39 to
d776425
Compare
2524193 to
6131e1e
Compare
d776425 to
664772c
Compare
6131e1e to
3cbea70
Compare
c26269c to
8889489
Compare
1edc40c to
ebad0ac
Compare
8889489 to
cf1ee30
Compare
ebad0ac to
321266f
Compare
🎩 To tophat this PR:You can add the following URL parameter to your browser to tophat this PR: |
321266f to
101a28f
Compare
cf1ee30 to
4083ce3
Compare
|
Feature suggestion: Maybe it would be easier in the future to have up/down buttons for nodes that can detect other nodes that are behind them, then automatically jump to the z-index of those nodes +1/-1. That way, you can visually move nodes higher or lower than other nodes below them / above them, without worrying about the exact z-index value. Edit: Oh, I just discovered the physical buttons! 🎉 |
|
I tested the buttons and it might be nice if we improved it so that it had that node-detection and ability to jump to the most relevant z-index based on what is currently above or behind. Otherwise, what I experienced was I clicked the button 20+ times before it visually made a difference. The "Bring to Front" or "Send to Back" options do serve that purpose but I wonder if our "Move Forward" and "Move Backward" options could be more intelligent. |
4083ce3 to
7c6cbc9
Compare
101a28f to
5c7401b
Compare
7c6cbc9 to
d5f64e2
Compare
5c7401b to
0ea6fa9
Compare
d5f64e2 to
ddd857b
Compare

Description
zIndex management for Task Nodes, accessible in UI via Context Panel & Configuration. zIndex is saved in annotations as
annotations: { zIndex: number.toString() }I didn't know where to stick the UI for it so just shoved it at the bottom of the Context Panel. It'd be nice to have a little floating toolbar above the node, but this is a sidequest, so it's something we can iterate on later.
Related Issue and Pull requests
Progresses https://github.com/Shopify/oasis-frontend/issues/483
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
Additional Comments