Skip to content

feat: zIndex Management for Task Nodes#1757

Merged
camielvs merged 1 commit intomasterfrom
02-04-temp_feat_zindex_management_for_task_nodes
Mar 5, 2026
Merged

feat: zIndex Management for Task Nodes#1757
camielvs merged 1 commit intomasterfrom
02-04-temp_feat_zindex_management_for_task_nodes

Conversation

@camielvs
Copy link
Copy Markdown
Collaborator

@camielvs camielvs commented Feb 5, 2026

Description

zIndex management for Task Nodes, accessible in UI via Context Panel & Configuration. zIndex is saved in annotations as annotations: { zIndex: number.toString() }

I didn't know where to stick the UI for it so just shoved it at the bottom of the Context Panel. It'd be nice to have a little floating toolbar above the node, but this is a sidequest, so it's something we can iterate on later.

Related Issue and Pull requests

Progresses https://github.com/Shopify/oasis-frontend/issues/483

Type of Change

  • New feature

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

image.png

Test Instructions

  • Add a bunch of tasks to the Canvas
  • Click on one of them. In the Context Panel you will see Stacking Controls at the bottom of the panel.
  • Confirm that each of these buttons works as expected.
  • Go to the Configuration Tab on a Task. Confirm that manually editing the zIndex annotation also works as expected.

Additional Comments

Copy link
Copy Markdown
Collaborator Author

camielvs commented Feb 5, 2026

@camielvs camielvs force-pushed the 02-04-temp_feat_zindex_management_for_task_nodes branch from f61141b to 8a478b7 Compare February 5, 2026 19:07
@camielvs camielvs changed the title temp: zIndex Management for Task Nodes feat: zIndex Management for Task Nodes Feb 5, 2026
@camielvs camielvs changed the base branch from 02-04-feat_add_zindex_management_for_all_nodes to graphite-base/1757 February 5, 2026 19:24
@camielvs camielvs force-pushed the 02-04-temp_feat_zindex_management_for_task_nodes branch from 8a478b7 to c39283b Compare February 5, 2026 19:24
@camielvs camielvs changed the base branch from graphite-base/1757 to 02-05-chore_add_integer_annotation_type February 5, 2026 19:25
@camielvs camielvs mentioned this pull request Feb 5, 2026
3 tasks
@camielvs camielvs force-pushed the 02-05-chore_add_integer_annotation_type branch from 72b3649 to f9add7a Compare February 5, 2026 19:35
@camielvs camielvs force-pushed the 02-04-temp_feat_zindex_management_for_task_nodes branch 2 times, most recently from 1d06dfb to fcd9564 Compare February 5, 2026 20:23
@camielvs camielvs force-pushed the 02-04-temp_feat_zindex_management_for_task_nodes branch from fcd9564 to 5026c52 Compare February 5, 2026 20:29
@camielvs camielvs force-pushed the 02-05-chore_add_integer_annotation_type branch from f9add7a to d9a6362 Compare February 5, 2026 21:42
@camielvs camielvs force-pushed the 02-04-temp_feat_zindex_management_for_task_nodes branch from 5026c52 to ee6ff89 Compare February 5, 2026 21:42
@camielvs camielvs force-pushed the 02-05-chore_add_integer_annotation_type branch from 9b3b118 to c6d3736 Compare February 18, 2026 23:19
@camielvs camielvs force-pushed the 02-04-temp_feat_zindex_management_for_task_nodes branch 2 times, most recently from 69a9e3f to 28aaa39 Compare February 19, 2026 00:23
@camielvs camielvs force-pushed the 02-05-chore_add_integer_annotation_type branch from c6d3736 to 2524193 Compare February 19, 2026 00:23
@camielvs camielvs force-pushed the 02-04-temp_feat_zindex_management_for_task_nodes branch from 28aaa39 to d776425 Compare February 19, 2026 17:59
@camielvs camielvs force-pushed the 02-05-chore_add_integer_annotation_type branch from 2524193 to 6131e1e Compare February 19, 2026 17:59
@camielvs camielvs force-pushed the 02-04-temp_feat_zindex_management_for_task_nodes branch from d776425 to 664772c Compare February 19, 2026 20:04
@camielvs camielvs force-pushed the 02-05-chore_add_integer_annotation_type branch from 6131e1e to 3cbea70 Compare February 19, 2026 20:04
@camielvs camielvs force-pushed the 02-04-temp_feat_zindex_management_for_task_nodes branch 2 times, most recently from c26269c to 8889489 Compare February 19, 2026 23:00
@camielvs camielvs force-pushed the 02-05-chore_add_integer_annotation_type branch from 1edc40c to ebad0ac Compare February 19, 2026 23:00
@camielvs camielvs force-pushed the 02-04-temp_feat_zindex_management_for_task_nodes branch from 8889489 to cf1ee30 Compare March 2, 2026 21:48
@camielvs camielvs force-pushed the 02-05-chore_add_integer_annotation_type branch from ebad0ac to 321266f Compare March 2, 2026 21:48
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 2, 2026

🎩 To tophat this PR:

You can add the following URL parameter to your browser to tophat this PR:

`?tophat_location=02-04-temp_feat_zindex_management_for_task_nodes/ddd857b`

@camielvs camielvs force-pushed the 02-05-chore_add_integer_annotation_type branch from 321266f to 101a28f Compare March 3, 2026 00:13
@camielvs camielvs force-pushed the 02-04-temp_feat_zindex_management_for_task_nodes branch from cf1ee30 to 4083ce3 Compare March 3, 2026 00:13
Copy link
Copy Markdown

morgan-wowk commented Mar 5, 2026

Feature suggestion:

Maybe it would be easier in the future to have up/down buttons for nodes that can detect other nodes that are behind them, then automatically jump to the z-index of those nodes +1/-1. That way, you can visually move nodes higher or lower than other nodes below them / above them, without worrying about the exact z-index value.

Edit: Oh, I just discovered the physical buttons! 🎉

Copy link
Copy Markdown

I tested the buttons and it might be nice if we improved it so that it had that node-detection and ability to jump to the most relevant z-index based on what is currently above or behind. Otherwise, what I experienced was I clicked the button 20+ times before it visually made a difference. The "Bring to Front" or "Send to Back" options do serve that purpose but I wonder if our "Move Forward" and "Move Backward" options could be more intelligent.

@camielvs camielvs force-pushed the 02-04-temp_feat_zindex_management_for_task_nodes branch from 4083ce3 to 7c6cbc9 Compare March 5, 2026 02:32
@camielvs camielvs force-pushed the 02-05-chore_add_integer_annotation_type branch from 101a28f to 5c7401b Compare March 5, 2026 02:32
@camielvs camielvs force-pushed the 02-04-temp_feat_zindex_management_for_task_nodes branch from 7c6cbc9 to d5f64e2 Compare March 5, 2026 21:25
@camielvs camielvs force-pushed the 02-05-chore_add_integer_annotation_type branch from 5c7401b to 0ea6fa9 Compare March 5, 2026 21:25
Copy link
Copy Markdown
Collaborator Author

camielvs commented Mar 5, 2026

Merge activity

  • Mar 5, 9:29 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 5, 9:32 PM UTC: Graphite rebased this pull request as part of a merge.
  • Mar 5, 9:34 PM UTC: @camielvs merged this pull request with Graphite.

@camielvs camielvs changed the base branch from 02-05-chore_add_integer_annotation_type to graphite-base/1757 March 5, 2026 21:29
@camielvs camielvs changed the base branch from graphite-base/1757 to master March 5, 2026 21:31
@camielvs camielvs force-pushed the 02-04-temp_feat_zindex_management_for_task_nodes branch from d5f64e2 to ddd857b Compare March 5, 2026 21:32
@camielvs camielvs merged commit a953092 into master Mar 5, 2026
17 checks passed
@camielvs camielvs deleted the 02-04-temp_feat_zindex_management_for_task_nodes branch March 5, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants