feat: Lock Flex Nodes

[camielvs]

Description

As suggested by @maxy-shpfy this PR adds the ability to "lock" sticky notes, preventing them from being selected or moved.

This is achieved by hovering over a sticky note and clicking the lock icon in the top right. A locked sticky note will show the lock icon in the top right at all times (an unlocked one will only show when hovered). To unlock a sticky note either click the lock again, or double click the note.

Alternatively, the lock functionality can be accessed via the flex node context panel.

Related Issue and Pull requests

Type of Change

• New feature

Checklist

• I have tested this does not break current pipelines / runs functionality
• I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

• Add a sticky note to convas
• Hover over it, you should see the lock icon appear in the top-right
• Click the lock to lock the sticky note. You should no longer be able to select the sticky note.
• Unlock it by clicking the lock icon, or by double-clicking the node.

Additional Comments

[camielvs]

• feat: Edit FlexNode Titles via Double-Click #1837
• chore: Add FlexNode Update Hook #1836
• feat: Variable Font Size for Flex Nodes #1832
• feat: Lock Flex Nodes #1826 👈 (View in Graphite)
• feat: Transparent Flex Nodes can have a Border #1784
• feat: Double-Click to Edit Flex Nodes in-place #1783
• feat: (Un)Pack Flex Nodes into Subgraphs #1769
• feat: Duplicate Flex Nodes #1768
• feat: zIndex Management for Flex Nodes #1755
• feat: Resizable Flex Nodes #1743 : 1 other dependent PR (#1744 )
• feat: Add Color Picker #1738
• feat: Edit Sticky Note Content #1737
• feat: Context Panel for Flex Nodes #1735 : 1 other dependent PR (#1736 )
• feat: Delete Flex Nodes #1746 : 1 other dependent PR (#1747 )
• feat: Add Sticky Notes to Canvas #1729 : 1 other dependent PR (#1745 )
• feat: Add Basic FlexNode #1728
• feat: Add StackingControls for Managing zIndex #1756 : 1 other dependent PR (#1758 )
• chore: Node Definition Cleanup #1731
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[maxy-shpfy]

the stcky node remain movebable in locked state

[camielvs]

Ah, I thought the ask was only for non-selectable. I can do non-moveable as well

[maxy-shpfy]

The lock button is really hard to see or click while zooming in/out. Could be an issue for users to find the feature - low contrast small icon. Only educated users will find it.

[maxy-shpfy]

Works nice! I left some comments.

I suggest to think about making icon more contrast and visible.

[camielvs]

I want to keep the icon on the node itself small and out of the way.

It might not be the best alternative but I have added the lock toggle to the context panel as well, beside the title. I also made the node clickable even when locked - but not editable.

[camielvs]

Merge activity

• Feb 26, 4:28 AM UTC: A user started a stack merge that includes this pull request via Graphite.
• Feb 26, 4:28 AM UTC: @camielvs merged this pull request with Graphite.