fix: use context manager for file operations in cardiology_detect.py (Fixes #1171)#1172
Open
rtmalikian wants to merge 1 commit into
Open
Conversation
Replace 5 bare open().readlines() calls with 'with open() as f' context managers to ensure proper file handle cleanup. The previous pattern relied on CPython reference counting for cleanup, which is not guaranteed across all Python implementations. Signed-off-by: rtmalikian <rtmalikian@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1171
Problem
pyhealth/tasks/cardiology_detect.pyuses bareopen().readlines()calls in 5 places. These rely on CPython's reference counting for file handle cleanup, which is not guaranteed behavior across all Python implementations.Root Cause
The original code uses the pattern:
This leaves the file handle cleanup to garbage collection rather than explicit resource management.
Solution
Replaced all 5 occurrences with
with open() as f:context managers:Verification
grep -c "= open(" pyhealth/tasks/cardiology_detect.py→ 0 (all bare open calls removed)ast.parse(): syntax check passesgit diff: 10 insertions, 5 deletions across 5 sitesChangelog
Files Changed
open().readlines()calls inwithstatementsVerification
About the Author: Raphael Malikian — Clinical AI Solutions Architect. I specialise in building and fixing AI/ML systems for healthcare, including vector databases, RAG pipelines, and clinical NLP. If you need help with your project or think I can add value to your organisation, feel free to reach out — I'd love to connect.
📧 rtmalikian@gmail.com
🔗 GitHub: https://github.com/rtmalikian
🔗 LinkedIn: http://www.linkedin.com/in/raphael-t-malikian-mbbs-bsc-hons-71075436a
Disclosure: This code was developed with assistance from DeepSeek-V4 (DeepSeek) via Hermes Agent (Nous Research). All changes were reviewed, tested against the actual codebase, and verified for correctness.