fix: Deduplicate nix-shell inputs to fix "Argument list too long" error#573
Open
fix: Deduplicate nix-shell inputs to fix "Argument list too long" error#573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
➜ secret-operator git:(main) nix-shell error: executing shell '/nix/store/5p86w1968gs5abgqkj9wv5gccxpy253c-bash-interactive-5.3p3/bin/bash': Argument list too longThe buildInputs and nativeBuildInputs lists were constructed by concatMapping over all transitive crate dependencies without deduplication. Since hundreds of crates share the same native build inputs (Rust compiler, linker, pkg-config, etc.), identical store paths were repeated hundreds of times, bloating PATH and other environment variables beyond the kernel's ARG_MAX limit.
Wrapping both lists with pkgs.lib.unique eliminates the duplicates and brings the environment size back within limits.
PS: Generated using Claude