Skip to content

fix(i18n): dynamic plugin menu items not getting translated #4348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Mar 18, 2026
Merged

fix(i18n): dynamic plugin menu items not getting translated #4348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions packages/app/src/utils/dynamicUI/extractDynamicConfigFrontend.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,47 @@ describe('buildTree', () => {
createMenuItem('item4', 'Item 4', 'icon4'),
],
},
{
description:
'should preserve title/titleKey/icon/to from first entry when merging same name (e.g. dynamic route + menuItems parent)',
input: [
{
name: 'default.admin',
title: 'Administration',
titleKey: 'menuItem.administration',
icon: 'admin',
children: [],
},
{
name: 'extensions',
title: 'Extensions',
titleKey: 'menuItem.extensions',
parent: 'default.admin',
icon: 'pluginsIcon',
to: '/extensions',
children: [],
} as MenuItem,
],
expectedOutput: [
{
name: 'default.admin',
title: 'Administration',
titleKey: 'menuItem.administration',
icon: 'admin',
children: [
{
name: 'extensions',
title: 'Extensions',
titleKey: 'menuItem.extensions',
icon: 'pluginsIcon',
to: '/extensions',
parent: 'default.admin',
children: [],
},
],
},
],
},
];

it.each(testCases)('$description', ({ input, expectedOutput }) => {
Expand Down
10 changes: 8 additions & 2 deletions packages/app/src/utils/dynamicUI/extractDynamicConfigFrontend.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,16 @@ export function buildTree(menuItemsArray: MenuItem[]): MenuItem[] {
if (!itemMap[item.name]) {
itemMap[item.name] = { ...item, children: [] };
} else {
const existing = itemMap[item.name];
itemMap[item.name] = {
...itemMap[item.name],
...existing,
...item,
children: itemMap[item.name].children,
children: existing.children,
// Preserve from existing when incoming has none (e.g. menuItems only adds parent)
title: item.title ?? existing.title,
titleKey: item.titleKey ?? existing.titleKey,
icon: item.icon ?? existing.icon,
to: item.to ?? existing.to,
};
}
});
Expand Down
Loading