Skip to content

fix(i18n): dynamic plugin menu items not getting translated#4348

Merged
openshift-merge-bot[bot] merged 1 commit intoredhat-developer:mainfrom
ciiay:fix-dynamic-plugin-menu-item-translation
Mar 18, 2026
Merged

fix(i18n): dynamic plugin menu items not getting translated#4348
openshift-merge-bot[bot] merged 1 commit intoredhat-developer:mainfrom
ciiay:fix-dynamic-plugin-menu-item-translation

Conversation

@ciiay
Copy link
Copy Markdown
Member

@ciiay ciiay commented Mar 3, 2026

Description

This PR fix the dynamic plugin menu item label not being translated issue.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Before:
image

After:
image

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 3, 2026

Image was built and published successfully. It is available at:

Copy link
Copy Markdown
Member

@lokanandaprabhu lokanandaprabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ciiay , I tested this on cluster but I am not able to see some plugin translations are working, ex Bulk import

image
image

i18n-tranalting menu items

Copy link
Copy Markdown
Contributor

@HusneShabbir HusneShabbir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to Prabhu's findings.

Also, why is the "Adoption Insights" menu item only being translated for selective locales? Shouldn't it be translated across all of them?

Screen.Recording.2026-03-06.at.12.04.57.PM.mov

@github-actions
Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

@github-actions github-actions bot added the Stale label Mar 14, 2026
Signed-off-by: Yi Cai <yicai@redhat.com>
@ciiay ciiay force-pushed the fix-dynamic-plugin-menu-item-translation branch from 660a530 to 7e1ff56 Compare March 18, 2026 00:55
@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@ciiay
Copy link
Copy Markdown
Member Author

ciiay commented Mar 18, 2026

Hi @lokanandaprabhu @HusneShabbir , thanks for the review. This PR only fixes the menu items that are listed in the translation files not getting translated issues. For example, both Bulk import and Extensions are listed in the Japanese translation file menuItem. sections, but not being translated. For Adoption Insights, you can see in all translation files, it's being left as the English words, which is supposed to be done on purpose. Let me know if you have further questions on this.

@github-actions github-actions bot removed the Stale label Mar 18, 2026
Copy link
Copy Markdown
Member

@lokanandaprabhu lokanandaprabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 18, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit 9db3505 into redhat-developer:main Mar 18, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants