Skip to content

fix node25 #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhheider merged 1 commit into from
Mar 2, 2026
Merged

fix node25 #297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions .github/workflows/ci.action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,21 @@ jobs:
- null
- /tmp/pkgx
include:
- os: ubuntu-latest
container: debian:buster-slim
- os: windows-latest
- os: ubuntu-latest
container: debian:buster-slim
- os: windows-latest
container: ${{ matrix.container }}
steps:
- uses: actions/checkout@v6

- name: install libatomic (required by Node 25+ on older distros)
if: ${{ matrix.container == 'debian:buster-slim' }}
run: |
# Debian buster is EOL, so we need to change mirrors
sed -i 's/deb\.debian/archive\.debian/g' /etc/apt/sources.list
apt-get update -qq
Comment on lines +53 to +55
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mirror rewrite for Debian buster is likely incomplete: the default buster-slim /etc/apt/sources.list typically includes security.debian.org entries and may also require disabling APT “Valid-Until” checks after EOL. With only deb.debian.* rewritten, apt-get update can still fail, breaking this job. Consider also rewriting/removing the security/updates entries and/or passing -o Acquire::Check-Valid-Until=false, or switch the container to a supported Debian release instead of buster.

Suggested change
# Debian buster is EOL, so we need to change mirrors
sed -i 's/deb\.debian/archive\.debian/g' /etc/apt/sources.list
apt-get update -qq
# Debian buster is EOL, so we need to change mirrors and relax APT checks
# Rewrite deb.debian.org and security.debian.org to archive.debian.org
sed -i -E 's/deb\.debian\.org/archive.debian.org/g; s/security\.debian\.org/archive.debian.org/g' /etc/apt/sources.list
# Disable Valid-Until checks so apt-get update works with archived metadata
apt-get -o Acquire::Check-Valid-Until=false update -qq

Copilot uses AI. Check for mistakes.
apt-get install -y libatomic1
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep CI containers smaller and reduce potential side effects, consider installing with --no-install-recommends and cleaning up /var/lib/apt/lists after installing libatomic1 (especially since this runs inside a slim base image).

Suggested change
apt-get install -y libatomic1
apt-get install -y --no-install-recommends libatomic1
apt-get clean
rm -rf /var/lib/apt/lists/*

Copilot uses AI. Check for mistakes.

- uses: actions/setup-node@v6
with:
node-version: latest
Expand Down Expand Up @@ -90,7 +98,7 @@ jobs:
- uses: ./
- run: npm run dist
- run: rm /usr/local/bin/pkgx
- run: '! pkgx --version'
- run: "! pkgx --version"
- run: git clean -xfd
- uses: ./
- run: pkgx --version
Expand Down
Loading