Conversation
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions workflow to keep CI passing now that Node.js 25+ requires libatomic1 on older Linux distributions (notably Debian Buster).
Changes:
- Adds an
apt-get install libatomic1step gated to thedebian:buster-slimcontainer matrix entry. - Fixes YAML indentation for the
matrix.includeentries (no functional change intended). - Adjusts quoting for the
! pkgx --versioncommand to avoid YAML parsing pitfalls.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Debian buster is EOL, so we need to change mirrors | ||
| sed -i 's/deb\.debian/archive\.debian/g' /etc/apt/sources.list | ||
| apt-get update -qq |
There was a problem hiding this comment.
The mirror rewrite for Debian buster is likely incomplete: the default buster-slim /etc/apt/sources.list typically includes security.debian.org entries and may also require disabling APT “Valid-Until” checks after EOL. With only deb.debian.* rewritten, apt-get update can still fail, breaking this job. Consider also rewriting/removing the security/updates entries and/or passing -o Acquire::Check-Valid-Until=false, or switch the container to a supported Debian release instead of buster.
| # Debian buster is EOL, so we need to change mirrors | |
| sed -i 's/deb\.debian/archive\.debian/g' /etc/apt/sources.list | |
| apt-get update -qq | |
| # Debian buster is EOL, so we need to change mirrors and relax APT checks | |
| # Rewrite deb.debian.org and security.debian.org to archive.debian.org | |
| sed -i -E 's/deb\.debian\.org/archive.debian.org/g; s/security\.debian\.org/archive.debian.org/g' /etc/apt/sources.list | |
| # Disable Valid-Until checks so apt-get update works with archived metadata | |
| apt-get -o Acquire::Check-Valid-Until=false update -qq |
| # Debian buster is EOL, so we need to change mirrors | ||
| sed -i 's/deb\.debian/archive\.debian/g' /etc/apt/sources.list | ||
| apt-get update -qq | ||
| apt-get install -y libatomic1 |
There was a problem hiding this comment.
To keep CI containers smaller and reduce potential side effects, consider installing with --no-install-recommends and cleaning up /var/lib/apt/lists after installing libatomic1 (especially since this runs inside a slim base image).
| apt-get install -y libatomic1 | |
| apt-get install -y --no-install-recommends libatomic1 | |
| apt-get clean | |
| rm -rf /var/lib/apt/lists/* |
node25 requires libatomic1.