Add the main manual links as XML entities - #2
Open
lacatoire wants to merge 2 commits into
Open
Conversation
lacatoire
force-pushed
the
initial-setup
branch
from
August 5, 2026 08:49
cc77e48 to
23bc771
Compare
Cross-references whose target stays in the main manual cannot use a linkend here, so they go through entities resolving to php.net links, declared as XML entities under entities/. The README gains a Creating this setup section for the build outside Docker.
lacatoire
force-pushed
the
initial-setup
branch
from
August 5, 2026 11:07
efa40ed to
c54fab8
Compare
Member
|
This is related to the recent doc-en change. Please use that file format as well. I think we would benefit from having a |
Cross-references whose target stays in the main manual cannot use a linkend here, so they go through entities resolving to php.net links. The file follows the format introduced in php/doc-en#5722, and the links are composed from a url.php.manual.en entity rather than repeating the base URL. The README gains a Creating this setup section for the build outside Docker.
Member
Author
|
Done @jordikroon, the file now follows the #5722 format, and the links are composed from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased on main now that #1 is in, so this only carries what is still missing.
Cross-references whose target stays in the main manual, such as the PECL installation chapter or the libxml book, cannot use a
linkendhere: there is no such target in this manual. They go through entities resolving to php.net links, declared as XML entities underentities/.The README gains a
Creating this setupsection for the build outside Docker.#10 builds on these entities.