Add the shared documentation snippets as XML entities - #10
Draft
lacatoire wants to merge 1 commit into
Draft
Conversation
The extension pages migrated out of the main manual reference snippets that live in doc-en/language-snippets.ent, which is not carried over. Without them the manual does not parse, as an undefined entity is a fatal XML error rather than a warning. They are added as XML entities under entities/, per the policy for this repository, rather than as DTD entities. Three of them link into the main manual and now go through the entities of entities/main-manual.ent instead of a linkend that has no target here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extension pages migrated out of the main manual reference snippets that are
defined in
doc-en/language-snippets.ent, a file this repository does not carryover. An undefined entity is a fatal XML error, not a warning, so the manual does
not parse without them.
Counting against the seven extensions prepared for migration (#3 to #9), 30 entities
would be undefined: 20 shared ones, added here, and 10 used by a single extension,
added in that extension's own pull request as
reference/<extension>/entities.ent,which
text-entities.phpcollects on its own.They are declared as XML entities under
entities/, not as DTD entities.Three of them link into the main manual,
pecl.info,libxml.requiredandpecl.windows.download. Theirlinkendhas no target in this manual, so they nowgo through the entities of
entities/main-manual.entadded in #2.