Onboard openshift/lightspeed-otel-collector on Prow CI

[blublinsky]

Summary

• Add Prow configuration (Tide, approve/lgtm plugins, triggers) for openshift/lightspeed-otel-collector
• Add CI operator config with fmt, unit, and vet presubmit checks (Go 1.25, multi-module)
• Add generated presubmit job definitions
• Add mirrored OWNERS files from the source repository

Details
lightspeed-otel-collector is a Go-based OpenTelemetry Collector with custom exporters/extensions for OpenShift Lightspeed. Builds are handled by Konflux; this PR enables Prow for code quality gates only.

Summary by CodeRabbit

Onboards openshift/lightspeed-otel-collector to OpenShift CI/Prow by wiring up repo-scoped Prow approval/LGTM plugins + triggers, Tide merge gating, and CI operator presubmit jobs (with builds still handled by Konflux, and Prow enforcing Go code quality gates).

• Adds generated OWNERS files with a fixed approvers list to both:
  • ci-operator/config/openshift/lightspeed-otel-collector/OWNERS
  • core-services/prow/02_config/openshift/lightspeed-otel-collector/OWNERS
• Configures Prow plugins/triggers for the repo:
  • approve (repo-scoped) with ignore_review_state: true and require_self_approval: true
  • lgtm (repo-scoped)
  • Trusted-app triggers for dependabot, red-hat-konflux, and openshift-merge-bot
• Adds Tide policy requiring PR labels approved and lgtm, and disallowing eligibility when any of the following are present: backports/unvalidated-commits, do-not-merge/hold, do-not-merge/invalid-owners-file, do-not-merge/work-in-progress, jira/invalid-bug, needs-rebase.
• Introduces CI operator presubmits for the multi-module Go project using the Go 1.25 build root image (rhel-9-release-golang-1.25-openshift-4.23):
  • fmt: GOFLAGS="-mod=readonly" ... make fmt && git diff --exit-code
  • unit: GOFLAGS="-mod=readonly" ... make test
  • vet: GOFLAGS="-mod=readonly" ... make vet
  • Skips runs when changes are only docs/markdown or common metadata (.gitignore, OWNERS, LICENSE), and sets default resources to 100m CPU / 2Gi memory requests and 4Gi memory limits.

(As part of the onboarding workflow, Prow rehearsals were requested and an /lgtm was applied during review.)

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 8b99e7dd-4e72-4578-9430-b17bc9bf62c8

📥 Commits

Reviewing files that changed from the base of the PR and between a318ba8 and 5c1f1c5.

⛔ Files ignored due to path filters (2)

• ci-operator/jobs/openshift/lightspeed-otel-collector/OWNERS is excluded by !ci-operator/jobs/**
• ci-operator/jobs/openshift/lightspeed-otel-collector/openshift-lightspeed-otel-collector-main-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (5)

• ci-operator/config/openshift/lightspeed-otel-collector/OWNERS
• ci-operator/config/openshift/lightspeed-otel-collector/openshift-lightspeed-otel-collector-main.yaml
• core-services/prow/02_config/openshift/lightspeed-otel-collector/OWNERS
• core-services/prow/02_config/openshift/lightspeed-otel-collector/_pluginconfig.yaml
• core-services/prow/02_config/openshift/lightspeed-otel-collector/_prowconfig.yaml

✅ Files skipped from review due to trivial changes (3)

• ci-operator/config/openshift/lightspeed-otel-collector/OWNERS
• core-services/prow/02_config/openshift/lightspeed-otel-collector/_prowconfig.yaml
• core-services/prow/02_config/openshift/lightspeed-otel-collector/OWNERS

🚧 Files skipped from review as they are similar to previous changes (2)

• core-services/prow/02_config/openshift/lightspeed-otel-collector/_pluginconfig.yaml
• ci-operator/config/openshift/lightspeed-otel-collector/openshift-lightspeed-otel-collector-main.yaml

---

Walkthrough

Adds repository ownership and Prow governance files for openshift/lightspeed-otel-collector, along with an OpenShift CI configuration defining the build image, resources, metadata, and format, unit, and vet tests.

Changes

Lightspeed OTel Collector integration

Layer / File(s)	Summary
OpenShift CI build and test configuration ci-operator/config/openshift/lightspeed-otel-collector/*	Defines the release build root, default resources, generated metadata, and fmt, unit, and vet tests with skip rules.
Repository ownership configuration ci-operator/config/openshift/lightspeed-otel-collector/OWNERS, core-services/prow/02_config/openshift/lightspeed-otel-collector/OWNERS	Adds approvers and empty reviewer/options settings for the repository’s CI and Prow configuration.
Prow plugin and Tide governance core-services/prow/02_config/openshift/lightspeed-otel-collector/_pluginconfig.yaml, core-services/prow/02_config/openshift/lightspeed-otel-collector/_prowconfig.yaml	Scopes approval and LGTM plugins, trusted applications, and Tide eligibility rules to the repository.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: lgtm, rehearsals-ack

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the PR’s main change: onboarding lightspeed-otel-collector on Prow CI.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	No Ginkgo test code changed; the PR only adds Prow/CI configs and OWNERS/job YAML, and searches found no It/Describe/Context/When titles.
Test Structure And Quality	✅ Passed	PR only adds CI/Prow config and OWNERS files; no Ginkgo test code or test behavior was changed, so the check is not applicable.
Microshift Test Compatibility	✅ Passed	The PR only adds generated CI/Prow config and OWNERS files; no new Ginkgo e2e tests or MicroShift-sensitive OpenShift API usage were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR only adds Prow/CI YAML and OWNERS files; no Ginkgo tests or SNO-sensitive multi-node assumptions were introduced.
Topology-Aware Scheduling Compatibility	✅ Passed	Only CI/Prow config and OWNERS files changed; no deployment/operator/controller code or scheduling fields were introduced.
Ote Binary Stdout Contract	✅ Passed	PR only adds CI/Prow/OWNERS config; no process-level Go code or suite setup touched, so no stdout-contract risk introduced.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; the PR only adds Prow/ci-operator config and generated job metadata, with no IPv4 or external-connectivity assumptions to review.
No-Weak-Crypto	✅ Passed	The PR only adds Prow/CI/OWNERS YAML; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons appear in the changed files.
Container-Privileges	✅ Passed	No new manifests set privileged:true, hostPID/Network/IPC, SYS_ADMIN, allowPrivilegeEscalation, or root user; the added CI/Prow configs use standard ci-operator pods.
No-Sensitive-Data-In-Logs	✅ Passed	PASS: The PR only adds CI/Prow YAML and OWNERS metadata; no logging code or plaintext secrets/PII are introduced, and no sensitive values appear in the added files.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[blublinsky]

/pj-rehearse

[openshift-merge-bot]

@blublinsky: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[blublinsky]

/pj-rehearse auto-ack

[openshift-merge-bot]

@blublinsky: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[raptorsun]

/lgtm

[blublinsky]

/pj-rehearse auto-ack

[openshift-merge-bot]

@blublinsky: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[blublinsky]

/pj-rehearse auto-ack

[openshift-merge-bot]

@blublinsky: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@blublinsky: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-lightspeed-otel-collector-main-fmt	openshift/lightspeed-otel-collector	presubmit	Presubmit changed
pull-ci-openshift-lightspeed-otel-collector-main-unit	openshift/lightspeed-otel-collector	presubmit	Presubmit changed
pull-ci-openshift-lightspeed-otel-collector-main-vet	openshift/lightspeed-otel-collector	presubmit	Presubmit changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[raptorsun]

/lgtm

[blublinsky]

/pj-rehearse auto-ack

[openshift-merge-bot]

@blublinsky: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[JoaoFula]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: blublinsky, JoaoFula, raptorsun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@blublinsky: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci]

@blublinsky: Updated the following 2 configmaps:

• config configmap in namespace ci at cluster app.ci using the following files:
  • key core-services-prow-02_config-openshift-lightspeed-otel-collector-_prowconfig.yaml using file core-services/prow/02_config/openshift/lightspeed-otel-collector/_prowconfig.yaml
• config configmap in namespace ci at cluster core-ci using the following files:
  • key core-services-prow-02_config-openshift-lightspeed-otel-collector-_prowconfig.yaml using file core-services/prow/02_config/openshift/lightspeed-otel-collector/_prowconfig.yaml

Details

In response to this:

Summary

• Add Prow configuration (Tide, approve/lgtm plugins, triggers) for openshift/lightspeed-otel-collector
• Add CI operator config with fmt, unit, and vet presubmit checks (Go 1.25, multi-module)
• Add generated presubmit job definitions
• Add mirrored OWNERS files from the source repository

Details
lightspeed-otel-collector is a Go-based OpenTelemetry Collector with custom exporters/extensions for OpenShift Lightspeed. Builds are handled by Konflux; this PR enables Prow for code quality gates only.

Summary by CodeRabbit

Onboards openshift/lightspeed-otel-collector to OpenShift CI/Prow by wiring up repo-scoped Prow approval/LGTM plugins + triggers, Tide merge gating, and CI operator presubmit jobs (with builds still handled by Konflux, and Prow enforcing Go code quality gates).

• Adds generated OWNERS files with a fixed approvers list to both:
• ci-operator/config/openshift/lightspeed-otel-collector/OWNERS
• core-services/prow/02_config/openshift/lightspeed-otel-collector/OWNERS
• Configures Prow plugins/triggers for the repo:
• approve (repo-scoped) with ignore_review_state: true and require_self_approval: true
• lgtm (repo-scoped)
• Trusted-app triggers for dependabot, red-hat-konflux, and openshift-merge-bot
• Adds Tide policy requiring PR labels approved and lgtm, and disallowing eligibility when any of the following are present: backports/unvalidated-commits, do-not-merge/hold, do-not-merge/invalid-owners-file, do-not-merge/work-in-progress, jira/invalid-bug, needs-rebase.
• Introduces CI operator presubmits for the multi-module Go project using the Go 1.25 build root image (rhel-9-release-golang-1.25-openshift-4.23):
• fmt: GOFLAGS="-mod=readonly" ... make fmt && git diff --exit-code
• unit: GOFLAGS="-mod=readonly" ... make test
• vet: GOFLAGS="-mod=readonly" ... make vet
• Skips runs when changes are only docs/markdown or common metadata (.gitignore, OWNERS, LICENSE), and sets default resources to 100m CPU / 2Gi memory requests and 4Gi memory limits.

(As part of the onboarding workflow, Prow rehearsals were requested and an /lgtm was applied during review.)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.