[ROSAENG-61017] Onboard openshift-online/rosa-trusted-actions to Prow - #81734
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (5)
WalkthroughThe change onboards ChangesROSA Trusted Actions onboarding
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ci-operator/config/openshift-online/rosa-trusted-actions/openshift-online-rosa-trusted-actions-main.yaml (1)
4-4: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winPin the build-root image instead of using
:latest.Use an immutable digest or explicitly versioned image tag so CI behavior cannot change without a reviewed configuration change.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift-online/rosa-trusted-actions/openshift-online-rosa-trusted-actions-main.yaml` at line 4, Replace the floating :latest tag in the build-root image declaration with an immutable digest or explicitly versioned Node.js image tag, ensuring future image updates require a reviewed configuration change.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@ci-operator/config/openshift-online/rosa-trusted-actions/openshift-online-rosa-trusted-actions-main.yaml`:
- Line 4: Replace the floating :latest tag in the build-root image declaration
with an immutable digest or explicitly versioned Node.js image tag, ensuring
future image updates require a reviewed configuration change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: f4d0de2d-efda-46b4-9b57-1143a0f2c3c4
⛔ Files ignored due to path filters (2)
ci-operator/jobs/openshift-online/rosa-trusted-actions/OWNERSis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-online/rosa-trusted-actions/openshift-online-rosa-trusted-actions-main-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (5)
ci-operator/config/openshift-online/rosa-trusted-actions/OWNERSci-operator/config/openshift-online/rosa-trusted-actions/openshift-online-rosa-trusted-actions-main.yamlcore-services/prow/02_config/openshift-online/rosa-trusted-actions/OWNERScore-services/prow/02_config/openshift-online/rosa-trusted-actions/_pluginconfig.yamlcore-services/prow/02_config/openshift-online/rosa-trusted-actions/_prowconfig.yaml
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
/pj-rehearse auto-ack |
|
@bergmannf: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-online-rosa-trusted-actions-main-validate-spec |
|
@bergmannf: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
359afff to
9721594
Compare
|
/retest-required |
|
/pj-rehearse pull-ci-openshift-online-rosa-trusted-actions-main-validate-spec |
|
@bergmannf: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Enable Prow merge automation (Tide + plugins) and add an OpenAPI spec validation presubmit job for rosa-trusted-actions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
9721594 to
d7ade1f
Compare
|
/pj-rehearse pull-ci-openshift-online-rosa-trusted-actions-main-validate-spec |
|
@bergmannf: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-online-rosa-trusted-actions-main-validate-spec |
|
@bergmannf: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/test core-valid |
|
@bergmannf: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bergmannf, gvnnn, tiwillia The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/pj-rehearse ack |
|
@bergmannf: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
@bergmannf: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Enable Prow merge automation (Tide + plugins) and add an OpenAPI spec validation presubmit job for rosa-trusted-actions. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
3 participants
Enable Prow merge automation (Tide + plugins) and add an OpenAPI spec validation presubmit job for rosa-trusted-actions.
This is a draft as we are still in the process of renaming the repository from rosa-trusted-actions-server to rosa-trusted-actions
Summary by CodeRabbit
openshift-online/rosa-trusted-actionsto OpenShift CI/Prow by adding CI-operator config for theopenshift-online-rosa-trusted-actions-mainbranch withprowgen.expose: true.validate-specpresubmit that runsHOME=/tmp make validate-specin the generated container to validate the repository’s OpenAPI spec.approvedandlgtm, and preventing merges when specific “do-not-merge”/rebase-related labels are present (includingneeds-rebaseanddo-not-merge/invalid-owners-file).openshift-merge-botwith repo-scoped plugin setup, including anapprovepolicy wherelgtmacts as approve, requiring self-approval, plus an externalneeds-rebaseplugin (wired toissue_commentandpull_request).OWNERSconfig for the relevant CI and Prow paths, defining the same approver/reviewer login sets and an emptyoptionsblock.