Skip to content

[release-4.22] OCPBUGS-104545: pkg/cvo/egress: Disable Proxy respect on HyperShift - #1438

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-1357-to-release-4.22
Aug 5, 2026
Merged

[release-4.22] OCPBUGS-104545: pkg/cvo/egress: Disable Proxy respect on HyperShift#1438
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-1357-to-release-4.22

Conversation

@openshift-cherrypick-robot

@openshift-cherrypick-robot openshift-cherrypick-robot commented Aug 4, 2026

Copy link
Copy Markdown

This is an automated cherry-pick of #1357

/assign judexzhu

@wking @openshift-cherrypick-robot
pkg/cvo/egress: Disable Proxy respect on HyperShift
e70ce2b 
Since 4.14, HostedCluster has had spec.configuration.proxy to
configure the data-plane egress [1].  In 4.18, the HyperShift API
began documenting that setting as specific to data-plane egress [2].
However, the cluster-version operator running on the
management-cluster control plane has assumed that hosted-cluster Proxy
resource should configure its own egress as well.  I’m not sure how
folks expect management-cluster-side control-plane egress to be
configured, but we don’t want it to respect spec.configuration.proxy,
because management-cluster networking and data-plane-compute
networking are very different environments.  For now, just ignore the
knob on HyperShift, to avoid data-plane-specific-network-config
breaking Update Service access, with ClusterVersionRetrievedUpdates
messages like:

  Unable to retrieve available updates: Get "https://api.openshift.com/api/upgrades_info/v1/graph?...": proxyconnect tcp: dial tcp: lookup ... on ...:53: no such host

[1]: https://github.com/openshift/hypershift/blame/b11c804b44516f34e50344eeb94901936018d9d1/api/v1beta1/hostedcluster_types.go#L2165-L2167
[2]: https://github.com/openshift/hypershift/blame/0d2075c649ed99657f6c5f90a0d273b8f99e9bc2/api/hypershift/v1beta1/hostedcluster_types.go#L1719-L1727
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 4, 2026
Merged
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c0e08149-1b69-4f69-b814-347373087f48

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci-robot

openshift-ci-robot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-79358 has been cloned as Jira Issue OCPBUGS-104545. Will retitle bug to link to clone.
/retitle [release-4.22] OCPBUGS-104545: pkg/cvo/egress: Disable Proxy respect on HyperShift

Details

In response to this:

This is an automated cherry-pick of #1357

/assign judexzhu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.22] OCPBUGS-79358: pkg/cvo/egress: Disable Proxy respect on HyperShift [release-4.22] OCPBUGS-104545: pkg/cvo/egress: Disable Proxy respect on HyperShift Aug 4, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 4, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-104545, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-79358 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-79358 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #1357

/assign judexzhu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@judexzhu

judexzhu commented Aug 4, 2026

Copy link
Copy Markdown

/retest-required

wking
wking approved these changes Aug 4, 2026
View reviewed changes

@wking wking left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 4, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2026
@openshift-ci

openshift-ci Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2026
@openshift-ci

openshift-ci Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@wking

wking commented Aug 5, 2026

Copy link
Copy Markdown
Member

/verified by passing CI presubmits. I'm not sure if some of the HyperShift presubmits cover a HostedCluster that configures a proxy or not, but passing presubmits is at least a positive sign that this isn't introducing serious regressions

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 5, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

@wking: This PR has been marked as verified by passing CI presubmits. I'm not sure if some of the HyperShift presubmits cover a HostedCluster that configures a proxy or not,but passing presubmits is at least a positive sign that this isn't introducing serious regressions.

Details

In response to this:

/verified by passing CI presubmits. I'm not sure if some of the HyperShift presubmits cover a HostedCluster that configures a proxy or not, but passing presubmits is at least a positive sign that this isn't introducing serious regressions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 6ac86dc into openshift:release-4.22 Aug 5, 2026
18 checks passed
@openshift-ci-robot

openshift-ci-robot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-104545
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-104545 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is an automated cherry-pick of #1357

/assign judexzhu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot

openshift-merge-robot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Fix included in release 4.22.0-0.nightly-2026-08-05-104816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wking wking wking approved these changes

Assignees

@wking wking

@judexzhu judexzhu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@openshift-cherrypick-robot @openshift-ci-robot @judexzhu @wking @openshift-merge-robot