OCPBUGS-79358: pkg/cvo/egress: Disable Proxy respect on HyperShift by wking · Pull Request #1357 · openshift/cluster-version-operator

wking · 2026-03-23T16:33:04Z

Since 4.14, HostedCluster has had spec.configuration.proxy to configure the data-plane egress 1. In 4.18, the HyperShift API began documenting that setting as specific to data-plane egress 2. However, the cluster-version operator running on the management-cluster control plane has assumed that hosted-cluster Proxy resource should configure its own egress as well. I’m not sure how folks expect management-cluster-side control-plane egress to be configured, but we don’t want it to respect spec.configuration.proxy, because management-cluster networking and data-plane-compute networking are very different environments. For now, just ignore the knob on HyperShift, to avoid data-plane-specific-network-config breaking Update Service access, with ClusterVersionRetrievedUpdates messages like:

Unable to retrieve available updates: Get "https://api.openshift.com/api/upgrades_info/v1/graph?...": proxyconnect tcp: dial tcp: lookup ... on ...:53: no such host

Since 4.14, HostedCluster has had spec.configuration.proxy to configure the data-plane egress [1]. In 4.18, the HyperShift API began documenting that setting as specific to data-plane egress [2]. However, the cluster-version operator running on the management-cluster control plane has assumed that hosted-cluster Proxy resource should configure its own egress as well. I’m not sure how folks expect management-cluster-side control-plane egress to be configured, but we don’t want it to respect spec.configuration.proxy, because management-cluster networking and data-plane-compute networking are very different environments. For now, just ignore the knob on HyperShift, to avoid data-plane-specific-network-config breaking Update Service access, with ClusterVersionRetrievedUpdates messages like: Unable to retrieve available updates: Get "https://api.openshift.com/api/upgrades_info/v1/graph?...": proxyconnect tcp: dial tcp: lookup ... on ...:53: no such host [1]: https://github.com/openshift/hypershift/blame/b11c804b44516f34e50344eeb94901936018d9d1/api/v1beta1/hostedcluster_types.go#L2165-L2167 [2]: https://github.com/openshift/hypershift/blame/0d2075c649ed99657f6c5f90a0d273b8f99e9bc2/api/hypershift/v1beta1/hostedcluster_types.go#L1719-L1727

openshift-ci-robot · 2026-03-23T16:33:11Z

@wking: This pull request references Jira Issue OCPBUGS-79358, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Since 4.14, HostedCluster has had spec.configuration.proxy to configure the data-plane egress 1. In 4.18, the HyperShift API began documenting that setting as specific to data-plane egress 2. However, the cluster-version operator running on the management-cluster control plane has assumed that hosted-cluster Proxy resource should configure its own egress as well. I’m not sure how folks expect management-cluster-side control-plane egress to be configured, but we don’t want it to respect spec.configuration.proxy, because management-cluster networking and data-plane-compute networking are very different environments. For now, just ignore the knob on HyperShift, to avoid data-plane-specific-network-config breaking Update Service access, with ClusterVersionRetrievedUpdates messages like:

Unable to retrieve available updates: Get "https://api.openshift.com/api/upgrades_info/v1/graph?...": proxyconnect tcp: dial tcp: lookup ... on ...:53: no such host

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-03-23T16:33:23Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 731825f9-a11f-4903-a9ce-58ae65c6a601

📥 Commits

Reviewing files that changed from the base of the PR and between 0276666 and 895233f.

📒 Files selected for processing (1)

pkg/cvo/egress.go

Walkthrough

The getProxyConfig function in the cluster version operator's egress configuration module now returns (nil, nil) early when hypershift is enabled, skipping proxy configuration queries that are unnecessary in hypershift deployments.

Changes

Cohort / File(s)	Summary
Egress Configuration `pkg/cvo/egress.go`	Added early return in `getProxyConfig` when hypershift is enabled to avoid unnecessary proxy lister queries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2026-03-23T16:36:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [fao89,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2026-04-13T10:30:56Z

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

openshift-ci-robot · 2026-04-13T10:31:06Z

@openshift-bot: This pull request references Jira Issue OCPBUGS-79358, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

wking · 2026-08-04T01:45:48Z

/retest-required

wking · 2026-08-04T01:46:26Z

/label acknowledge-critical-fixes-only
/verified by CI (earlier HyperShift CI failures were unrelated to this pull)

openshift-ci-robot · 2026-08-04T01:46:39Z

@wking: This PR has been marked as verified by CI (earlier HyperShift CI failures were unrelated to this pull).

Details

In response to this:

/label acknowledge-critical-fixes-only
/verified by CI (earlier HyperShift CI failures were unrelated to this pull)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

judexzhu · 2026-08-04T17:15:52Z

/retest-required

wking · 2026-08-04T17:25:17Z

Kube API disruption between the test-suite and the standalone cluster-under-test is unrelated to this HyperShift-impacting pull:

/override ci/prow/e2e-agnostic-ovn

openshift-ci · 2026-08-04T17:25:36Z

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-ovn

Details

In response to this:

Kube API disruption between the test-suite and the standalone cluster-under-test is unrelated to this HyperShift-impacting pull:

/override ci/prow/e2e-agnostic-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2026-08-04T17:31:50Z

@wking: Jira Issue Verification Checks: Jira Issue OCPBUGS-79358
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-79358 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Since 4.14, HostedCluster has had spec.configuration.proxy to configure the data-plane egress 1. In 4.18, the HyperShift API began documenting that setting as specific to data-plane egress 2. However, the cluster-version operator running on the management-cluster control plane has assumed that hosted-cluster Proxy resource should configure its own egress as well. I’m not sure how folks expect management-cluster-side control-plane egress to be configured, but we don’t want it to respect spec.configuration.proxy, because management-cluster networking and data-plane-compute networking are very different environments. For now, just ignore the knob on HyperShift, to avoid data-plane-specific-network-config breaking Update Service access, with ClusterVersionRetrievedUpdates messages like:

Unable to retrieve available updates: Get "https://api.openshift.com/api/upgrades_info/v1/graph?...": proxyconnect tcp: dial tcp: lookup ... on ...:53: no such host

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-08-04T17:32:10Z

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

judexzhu · 2026-08-04T17:46:56Z

/cherry-pick release-4.22

openshift-cherrypick-robot · 2026-08-04T17:47:45Z

@judexzhu: new pull request created: #1438

Details

In response to this:

/cherry-pick release-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot · 2026-08-05T09:06:46Z

Fix included in release 5.0.0-0.nightly-2026-08-05-033721

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2026

fao89 approved these changes Mar 23, 2026

View reviewed changes

openshift-ci Bot assigned fao89 Mar 23, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2026

openshift-ci Bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Aug 4, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 4, 2026

openshift-merge-bot Bot merged commit 97ee3b7 into openshift:main Aug 4, 2026
19 checks passed

wking deleted the ignore-proxy-on-hypershift branch August 4, 2026 17:36

openshift-cherrypick-robot mentioned this pull request Aug 4, 2026

[release-4.22] OCPBUGS-104545: pkg/cvo/egress: Disable Proxy respect on HyperShift #1438

Merged

Uh oh!

Conversation

wking commented Mar 23, 2026

Uh oh!

openshift-ci-robot commented Mar 23, 2026

Uh oh!

coderabbitai Bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

openshift-ci Bot commented Mar 23, 2026

Uh oh!

openshift-bot commented Apr 13, 2026

Uh oh!

openshift-ci-robot commented Apr 13, 2026

Uh oh!

wking commented Aug 4, 2026

Uh oh!

wking commented Aug 4, 2026

Uh oh!

openshift-ci-robot commented Aug 4, 2026

Uh oh!

judexzhu commented Aug 4, 2026

Uh oh!

wking commented Aug 4, 2026

Uh oh!

openshift-ci Bot commented Aug 4, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 4, 2026

Uh oh!

openshift-ci Bot commented Aug 4, 2026

Uh oh!

judexzhu commented Aug 4, 2026

Uh oh!

openshift-cherrypick-robot commented Aug 4, 2026

Uh oh!

openshift-merge-robot commented Aug 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

coderabbitai Bot commented Mar 23, 2026 •

edited

Loading