fix(view): implement partial lock cleanup in lockFile#62349
Open
joshtrichards wants to merge 2 commits into
Open
fix(view): implement partial lock cleanup in lockFile#62349joshtrichards wants to merge 2 commits into
joshtrichards wants to merge 2 commits into
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
10 tasks
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
marked this pull request as ready for review
July 22, 2026 16:56
joshtrichards
requested review from
Altahrim,
come-nc,
icewind1991 and
leftybournes
and removed request for
a team
July 22, 2026 16:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
View::lockFile()roll back locks it has already acquired when acquiring a later parent lock fails.Previously,
lockFile()could leave the target path and earlier parent locks held after a later parent-lock acquisition failed. The method now tracks successful acquisitions and releases them in reverse order before rethrowing the original failure. Rollback is best-effort: cleanup failures are logged without masking the acquisition failure.This complements the cache-refresh cleanup change (#62345) by ensuring
lockFile()does not leave a partial lock set behind when acquisition itself fails.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)