Skip to content

fix(view): implement partial lock cleanup in lockFile#62349

Open
joshtrichards wants to merge 2 commits into
masterfrom
jtr/fix-view-lockFile-rollback
Open

fix(view): implement partial lock cleanup in lockFile#62349
joshtrichards wants to merge 2 commits into
masterfrom
jtr/fix-view-lockFile-rollback

Conversation

@joshtrichards

@joshtrichards joshtrichards commented Jul 20, 2026

Copy link
Copy Markdown
Member
  • Resolves: #

Summary

Make View::lockFile() roll back locks it has already acquired when acquiring a later parent lock fails.

Previously, lockFile() could leave the target path and earlier parent locks held after a later parent-lock acquisition failed. The method now tracks successful acquisitions and releases them in reverse order before rethrowing the original failure. Rollback is best-effort: cleanup failures are logged without masking the acquisition failure.

This complements the cache-refresh cleanup change (#62345) by ensuring lockFile() does not leave a partial lock set behind when acquisition itself fails.

TODO

  • Add test: parent-lock acquisition failure releases the file and already-acquired parents
  • Add test: a rollback unlock failure does not replace the acquisition exception

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added 3. to review Waiting for reviews bug and removed 2. developing Work in progress labels Jul 22, 2026
@joshtrichards
joshtrichards marked this pull request as ready for review July 22, 2026 16:56
@joshtrichards
joshtrichards requested a review from a team as a code owner July 22, 2026 16:56
@joshtrichards
joshtrichards requested review from Altahrim, come-nc, icewind1991 and leftybournes and removed request for a team July 22, 2026 16:56
@joshtrichards joshtrichards added the ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) label Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug feature: filesystem feature: locking ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant