fix(view): release cache refresh locks on errors#62345
Open
joshtrichards wants to merge 4 commits into
Open
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
9 tasks
Assisted-by: GitHub Copilot:GPT-5 Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
marked this pull request as ready for review
July 21, 2026 14:55
joshtrichards
requested review from
come-nc,
leftybournes,
nfebe and
sorbaugh
and removed request for
a team
July 21, 2026 14:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
View::getCacheEntry()so that, afterlockFile()succeeds, release of its file and parent-directory refresh locks is attempted infinally.Previously, the broad
LockedExceptionfallback also caught failures during refresh or lock release. That could skip cleanup and return cached metadata, leaving locks held until request shutdown and obscuring the cause of later lock contention.Lock contention during shallow scanning or initial lock acquisition remains best-effort and returns the existing cache entry. Once
lockFile()succeeds, however,getCacheEntry()owns the file and parent-directory refresh locks. A subsequent failure during refresh work or cleanup is no longer treated as initial lock contention: the method attempts release infinallyand propagates the failure.Follow-up ideas:
lockFile()does not roll back locks already acquired if acquiring a parent lock fails. Addressing that partial-acquisition cleanup remains out of scope. (Edit: implemented via fix(view): implement partial lock cleanup in lockFile #62349)basicOperation()has similar lock-cleanup responsibilities and could probably benefit from a similar approach. In particular, its current cleanup is inside acatch, so anunlockFile()failure could obscure the original storage exception.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)