Skip to content

fix(sharing): hide external sharing section when link sharing disabled #57630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nfebe wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −10
Open

fix(sharing): hide external sharing section when link sharing disabled #57630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b034fd3
fix(sharing): hide external sharing section when link sharing disabled
nfebe Jan 18, 2026
151823f
chore(assets): Recompile assets
nextcloud-command Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions apps/files_sharing/lib/Listener/LoadSidebarListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,9 @@ public function handle(Event $event): void {
$showFederatedToTrustedAsInternal = $gsConfig->isGlobalScaleEnabled() || $appConfig->getValueBool('files_sharing', ConfigLexicon::SHOW_FEDERATED_TO_TRUSTED_AS_INTERNAL);
$showFederatedAsInternal = ($gsConfig->isGlobalScaleEnabled() && $gsConfig->onlyInternalFederation())
|| $appConfig->getValueBool('files_sharing', ConfigLexicon::SHOW_FEDERATED_AS_INTERNAL);
$showExternalSharing = $appConfig->getValueBool('files_sharing', 'outgoing_server2server_share_enabled', true)
|| $appConfig->getValueBool('core', 'shareapi_allow_links', true);
$showExternalSharing = $appConfig->getValueBool('core', 'shareapi_allow_links', true)
Copy link
Contributor

@susnux susnux Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this also include mail shares?

Copy link
Contributor Author

@nfebe nfebe Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Mail shares are link shares under the hood

|| ($appConfig->getValueBool('files_sharing', 'outgoing_server2server_share_enabled', true)
&& !$showFederatedAsInternal);

$this->initialState->provideInitialState('showFederatedSharesAsInternal', $showFederatedAsInternal);
$this->initialState->provideInitialState('showFederatedSharesToTrustedServersAsInternal', $showFederatedToTrustedAsInternal);
Expand Down
2 changes: 1 addition & 1 deletion apps/files_sharing/src/views/SharingTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@

<section>
<div class="section-header">
<h4>{{ t('files_sharing', 'Internal shares') }}</h4>
<h4>{{ config.showExternalSharing ? t('files_sharing', 'Internal shares') : t('files_sharing', 'Shares') }}</h4>
<NcPopover popup-role="dialog">
<template #trigger>
<NcButton
Expand Down
2 changes: 2 additions & 0 deletions dist/5821-5821.js
View file
Open in desktop

Large diffs are not rendered by default.

0 dist/9429-9429.js.license → dist/5821-5821.js.license
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions dist/5821-5821.js.map
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions dist/5821-5821.js.map.license
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
5821-5821.js.license
2 changes: 0 additions & 2 deletions dist/9429-9429.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion dist/9429-9429.js.map
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion dist/9429-9429.js.map.license
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions dist/files_sharing-files_sharing_tab.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/files_sharing-files_sharing_tab.js.map
View file
Open in desktop

Large diffs are not rendered by default.

Loading