fix(sharing): hide external sharing section when link sharing disabled #57630
+11
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
requested review from
Altahrim,
come-nc and
szaimen
and removed request for
a team
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
susnux
reviewed
Jan 19, 2026
| || $appConfig->getValueBool('files_sharing', ConfigLexicon::SHOW_FEDERATED_AS_INTERNAL); | ||
| $showExternalSharing = $appConfig->getValueBool('files_sharing', 'outgoing_server2server_share_enabled', true) | ||
| || $appConfig->getValueBool('core', 'shareapi_allow_links', true); | ||
| $showExternalSharing = $appConfig->getValueBool('core', 'shareapi_allow_links', true) |
Contributor
There was a problem hiding this comment.
does this also include mail shares?
Contributor
Author
There was a problem hiding this comment.
Yes. Mail shares are link shares under the hood
nfebe
force-pushed
the
fix/hide-external-sharing-when-links-disabled
branch
2 times, most recently
from
8604fdb to
08f2c69
Compare
cristianscheid
approved these changes
Jan 27, 2026
Member
|
/backport to stable33 |
Only show the external sharing section when link sharing is enabled or when federation is enabled and not configured to show as internal. When external sharing is hidden, simplify the section label from "Internal shares" to "Shares". Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
fix/hide-external-sharing-when-links-disabled
branch
from
08f2c69 to
b034fd3
Compare
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only show the external sharing section when link sharing is enabled or when federation is enabled and not configured to show as internal. When external sharing is hidden, simplify the section label from "Internal shares" to "Shares".