sessions: add Dev Container workspace menu option - #335303
Merged
Megan Rogge (meganrogge) merged 14 commits intoSep 10, 2026
Merged
sessions: add Dev Container workspace menu option#335303Megan Rogge (meganrogge) merged 14 commits into
Megan Rogge (meganrogge) merged 14 commits into
Conversation
Copilot started reviewing on behalf of
Megan Rogge (meganrogge)
September 9, 2026 16:34
View session
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Ulugbek Abdullaev (@ulugbekna)Matched files:
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Availability caching and checkbox updates can leave the visible and ARIA workspace mode incorrect.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 2
New issues introduced by this change (2)
| Severity | Finding |
|---|---|
 |
src/vs/sessions/contrib/chat/browser/newChatWidget.ts — This only snapshots Dev Container state when the widget seeds from an active session. The existing… |
|
src/vs/sessions/contrib/chat/browser/sessionWorkspacePicker.ts — This caches both positive and negative availability for the provider's lifetime, but availability… |
What changed in this PR
Adds Dev Container execution to eligible local workspace rows in the Agents workspace picker.
Changes:
- Adds an availability-gated Use Dev Container submenu.
- Routes selection through the existing draft preference flow and updates visible/ARIA labels.
- Adds accessibility guidance and picker tests.
| File | Description |
|---|---|
agentHostSessionsProvider.ts |
Extends the provider contract with workspace availability. |
localAgentHostSessionsProvider.ts |
Delegates availability checks to the Dev Container service. |
sessionWorkspacePicker.ts |
Adds submenu selection, availability caching, and labels. |
newChatWidget.ts |
Applies and restores the Dev Container preference. |
sessionsChatAccessibilityHelp.ts |
Documents the workflow. |
sessionWorkspacePicker.test.ts |
Tests submenu gating, selection, and labels. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
roblourens
previously approved these changes
Sep 9, 2026
Megan Rogge (meganrogge)
added a commit
to meganrogge/vscode
that referenced
this pull request
Sep 9, 2026
Expose eligible local folders as native workspace-picker submenus and carry the selected Dev Container mode into draft creation and accessible labeling. Fixes microsoft#335302 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep the workspace label synchronized with active draft configuration, recheck live Dev Container availability on each picker open, and align the accessibility regression with the documented wording.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Megan Rogge (meganrogge)
force-pushed
the
agents/devcontainer-menu-integration
branch
from
September 9, 2026 18:38
0341f2a to
ecd8c03
Compare
Present local and Dev Container execution as checked choices, avoid duplicate submenu descriptions, and document switching back to local execution.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ulugbek Abdullaev (ulugbekna)
previously approved these changes
Sep 9, 2026
Use the workspace picker as the single Dev Container mode control while preserving worktree compatibility gating.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Megan Rogge (meganrogge)
enabled auto-merge (squash)
September 9, 2026 20:41
Drive Dev Container selection through the workspace submenu after removing the checkbox, and normalize incompatible worktree isolation before session preparation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ActionList ignores direct clicks on submenu indicators, so hover the workspace row before selecting the Dev Container child action. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
roblourens
previously approved these changes
Sep 9, 2026
roblourens
reviewed
Sep 9, 2026
roblourens
left a comment
roblourens
left a comment
Member
There was a problem hiding this comment.
[Experimental performance review bot]
Automated experimental performance review.
(Written by Copilot)
Cache and bound availability probes, refresh the picker in place after batched completion, and make smoke submenu hover deterministic. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Avoid relying on the delayed hover timer in Linux Electron smoke tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Vritant Bhardwaj (vritant24)
previously approved these changes
Sep 10, 2026
Use the action list's direct submenu activation instead of timing-sensitive pointer or focus behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dmitriy Vasyura (dmitrivMS)
previously approved these changes
Sep 10, 2026
Ignore the synthetic Remote provider submenu while waiting for the local workspace availability action. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Invalidate cached workspace availability when the Dev Container connector registers or unregisters so early negative probes do not become stale. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dmitriy Vasyura (dmitrivMS)
previously approved these changes
Sep 10, 2026
Christof Marti (chrmarti)
added a commit
that referenced
this pull request
Sep 10, 2026
Align the new sandbox picker test with #335303, which removes the redundant Dev Container checkbox. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Align the sandbox picker test with the removal of the redundant Dev Container checkbox. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Allow a workspace row with a historical non-Agent-Host provider to use a capable Agent Host provider for Dev Container availability checks. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
|
Updated the branch with current Validated on the clean update branch with client typecheck, full hygiene, 124 focused unit tests, and the green diagnostic matrix in #335414. |
Dirk Bäumer (dbaeumer)
approved these changes
Sep 10, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<folder> - Dev Container, including its ARIA labelFixes #335302
Validation
./scripts/test.sh --run src/vs/sessions/contrib/chat/test/browser/sessionWorkspacePicker.test.ts --run src/vs/sessions/contrib/chat/test/browser/newChatWidget.test.ts(110 passing)npm run eslint -- ...for all changed TypeScript filesnpm run hygienegit diff --check#317380