Skip to content

sessions: remove experimental tag from Dev Container setting - #335497

Merged
Christof Marti (chrmarti) merged 1 commit into
mainfrom
chrmarti/devcontainer-setting-stable
Sep 10, 2026
Merged

sessions: remove experimental tag from Dev Container setting#335497
Christof Marti (chrmarti) merged 1 commit into
mainfrom
chrmarti/devcontainer-setting-stable

Conversation

@chrmarti

@chrmarti Christof Marti (chrmarti) commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Follow-up to #335303.

Summary

  • remove the experimental Settings UI tag from chat.agentHost.devContainer.enabled
  • keep the setting disabled by default and retain its experiment: { mode: "auto" } rollout metadata
  • leave the hidden experimental Dev Container worktree-combination setting unchanged

Validation

  • npm run transpile-client
  • ./scripts/test.sh --run src/vs/sessions/contrib/providers/remoteAgentHost/test/electron-browser/devContainerAgentHostConnector.test.ts — 5 passing
  • npm run typecheck-client
  • npm run hygiene

#317380

Keep the disabled-by-default experimentation rollout while removing the experimental Settings UI marker from the public Dev Container Agent Host setting.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 10, 2026 16:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved review issues remain.

Review tier: Lite
Findings: None

What changed in this PR

Removes the visible experimental label from the Dev Container setting while preserving its disabled default and rollout metadata.

Changes:

  • Updates setting registration.
  • Updates configuration test expectations.
  • Leaves the hidden worktree setting unchanged.
File Description
src/​vs/​sessions/​contrib/​providers/​remoteAgentHost/​test/​electron-browser/​devContainerAgentHostConnector.test.ts Verifies updated setting metadata.
src/​vs/​sessions/​contrib/​providers/​remoteAgentHost/​electron-browser/​devContainerAgentHostConnector.contribution.ts Removes the visible experimental tag.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@chrmarti
Christof Marti (chrmarti) marked this pull request as ready for review September 10, 2026 16:37
@chrmarti
Christof Marti (chrmarti) merged commit deb0901 into main Sep 10, 2026
34 checks passed
@chrmarti
Christof Marti (chrmarti) deleted the chrmarti/devcontainer-setting-stable branch September 10, 2026 16:40
@vs-code-engineering vs-code-engineering Bot added this to the 1.138.0 milestone Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants