Skip to content

Add msr-tools package from upstream#17149

Merged
christopherco merged 1 commit into
4.0from
madagg/tomls/base/main/add-msr-tools-package
May 21, 2026
Merged

Add msr-tools package from upstream#17149
christopherco merged 1 commit into
4.0from
madagg/tomls/base/main/add-msr-tools-package

Conversation

@MadhurAggarwal
Copy link
Copy Markdown
Member

@MadhurAggarwal MadhurAggarwal commented May 12, 2026

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

  • Adds msr-tools package from upstream fedora sources
  • Ensured that it provides the required: rdmsr / wrmsr
  • This was required for fixing LISA P1 Test: verify_hyperv_platform_id which skips due to this missing package
Change Log
  • Added msr-tools package from upstream Fedora sources
  • Uploaded msr-tools source
image
Does this affect the toolchain?

NO

Associated issues

WorkItem: https://dev.azure.com/mariner-org/mariner/_workitems/edit/18998/

Test Methodology

Local RPM Build:
image

Koji build: https://purple-grass-0478bae1e.7.azurestaticapps.net/workflow/06fc9f45-c344-4fdd-c90b-08deb2c7ade9

@MadhurAggarwal MadhurAggarwal changed the title Madagg/tomls/base/main/add msr tools package Add msr-tools package from upstream May 12, 2026
Comment thread base/comps/msr-tools/msr-tools.comp.toml Outdated
@reubeno
Copy link
Copy Markdown
Member

reubeno commented May 12, 2026

@MadhurAggarwal -- I've merged your PR to azldev; can you try updating this PR?

@MadhurAggarwal MadhurAggarwal force-pushed the madagg/tomls/base/main/add-msr-tools-package branch from 2f7207f to cd55e9f Compare May 12, 2026 15:22
@MadhurAggarwal
Copy link
Copy Markdown
Member Author

MadhurAggarwal commented May 12, 2026

@MadhurAggarwal -- I've merged your PR to azldev; can you try updating this PR?

Thanks!
I've updated this PR to use the latest azldev build.
Attached local rpm build logs for msr-tool

@MadhurAggarwal MadhurAggarwal marked this pull request as ready for review May 12, 2026 15:29
Copilot AI review requested due to automatic review settings May 12, 2026 15:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the Fedora-imported msr-tools component/spec to the Azure Linux repo so the rdmsr / wrmsr utilities are available as a packaged dependency (e.g., for LISA validation scenarios).

Changes:

  • Added the msr-tools component to the Fedora-import list (components.toml) and introduced its lockfile.
  • Added rendered spec artifacts for msr-tools (spec, sources hash, and the upstream patch used by the spec).

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
specs/m/msr-tools/sources Adds the source tarball hash entry for the rendered component.
specs/m/msr-tools/msr-tools.spec Introduces the rendered RPM spec for building/packaging msr-tools.
specs/m/msr-tools/bz1268604-increase-max-procs.patch Adds the patch referenced by the spec to increase supported CPU index range.
locks/msr-tools.lock Adds the azldev-managed lock pinning the imported upstream commit and input fingerprint.
base/comps/components.toml Registers msr-tools as an unmodified Fedora-imported component (needs ordering fix per stored comment).

Comment thread base/comps/components.toml
reubeno

This comment was marked as resolved.

@MadhurAggarwal MadhurAggarwal force-pushed the madagg/tomls/base/main/add-msr-tools-package branch from e044c04 to 8915631 Compare May 13, 2026 06:06
christopherco

This comment was marked as resolved.

@MadhurAggarwal MadhurAggarwal force-pushed the madagg/tomls/base/main/add-msr-tools-package branch from 8915631 to 9c01a49 Compare May 18, 2026 05:11
@MadhurAggarwal MadhurAggarwal changed the base branch from tomls/base/main to 4.0 May 18, 2026 05:12
@MadhurAggarwal
Copy link
Copy Markdown
Member Author

Retarget to 4.0 branch

@reubeno
Copy link
Copy Markdown
Member

reubeno commented May 20, 2026

@christopherco Did you have any concerns around adding this new package? I'm supportive.

@christopherco
Copy link
Copy Markdown
Collaborator

@christopherco Did you have any concerns around adding this new package? I'm supportive.

No concerns on my side

Copy link
Copy Markdown
Collaborator

@christopherco christopherco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Please squash your changes together into 1 commit, so we can rebase-merge.

@MadhurAggarwal MadhurAggarwal force-pushed the madagg/tomls/base/main/add-msr-tools-package branch from 9c01a49 to 087056f Compare May 21, 2026 05:57
@MadhurAggarwal
Copy link
Copy Markdown
Member Author

MadhurAggarwal commented May 21, 2026

I've squashed the commits into 1 and rebased it to the latest 4.0
Latest Koji Package Build

@christopherco christopherco dismissed reubeno’s stale review May 21, 2026 06:34

chatted with @reubeno offline and this change looks good

@christopherco christopherco merged commit a99f6a0 into 4.0 May 21, 2026
11 checks passed
@christopherco christopherco deleted the madagg/tomls/base/main/add-msr-tools-package branch May 21, 2026 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants