fix: allow autobump for Non Conditional %{dist} Releases#179
Merged
reubeno merged 1 commit intoMay 12, 2026
Merged
Conversation
12 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Enables azldev’s automatic Release auto-bump logic to handle RPM specs that use a non-conditional dist macro (%{dist}) in addition to the existing conditional form (%{?dist}), aligning behavior with real-world Fedora spec usage.
Changes:
- Expanded the static Release matching regex to accept both
%{?dist}and%{dist}suffixes. - Updated unit tests to cover the new accepted
%{dist}form (and removed the prior rejection expectation). - Updated component release configuration documentation to reflect the newly supported Release formats.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/app/azldev/core/sources/release.go | Broadens staticReleasePattern to allow auto-bumping N%{dist} as well as N%{?dist}. |
| internal/app/azldev/core/sources/release_test.go | Adds acceptance coverage for 1%{dist} in BumpStaticRelease. |
| internal/app/azldev/core/sources/release_internal_test.go | Adds integration-style coverage ensuring tryBumpStaticRelease rewrites Release: 1%{dist} to the bumped value. |
| docs/user/reference/config/components.md | Documents that auto/static modes support static integer releases optionally suffixed by %{?dist} or %{dist}. |
reubeno
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
%{dist}and%{?dist}msr-toolsuses Non-conditional dist: https://src.fedoraproject.org/rpms/msr-tools/blob/rawhide/f/msr-tools.specLocal Build and Unit Test:
