Conversation
hekota
reviewed
Feb 17, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the DXIL operation definitions for linear algebra operations to align with the SM6.10 spec changes (microsoft/hlsl-specs#769). The changes modify how matrix operations handle matrix types, transitioning from i32 reference handles to proper object types and changing operations to return matrices instead of accepting them as output parameters.
Changes:
- Removed the
CreateMatrixDXIL operation (no longer needed) - Renamed reserved operations from
LinAlgMatrixReserved*toReservedD*for consistency - Updated all matrix operations to return matrix objects instead of accepting them as in/out parameters
- Changed matrix parameter types from i32 handles to object type 'o'
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| utils/hct/hctdb.py | Updated DXIL operation definitions: removed CreateMatrix, added ReservedD0, updated all matrix ops to use object types and return matrices |
| lib/DXIL/DxilOperations.cpp | Generated code reflecting operation signature changes, overload type handling, and reserved op renaming |
| include/dxc/DXIL/DxilInstructions.h | Generated instruction wrapper structs with updated parameter accessors and argument counts |
| include/dxc/DXIL/DxilConstants.h | Updated OpCode enums and OpCodeClass count to reflect CreateMatrix removal and reserved op renaming |
| docs/DXIL.rst | Updated documentation table with new operation names and descriptions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
microsoft/hlsl-specs#769 updated the signatures for the linalg DXIL ops. Update the implementation to reflect that
70eef1f to
3fd6faf
Compare
damyanp
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
microsoft/hlsl-specs#769 updated the signatures for the linalg DXIL ops. Update the implementation to reflect that
utils/hct/hctdb.pyis the interesting changes, everything else is generated code