Skip to content

[SM6.10][specs/769] Update DXIL Op Defs#8163

Merged
V-FEXrt merged 1 commit intomainfrom
linalg-specs-769
Feb 18, 2026
Merged

[SM6.10][specs/769] Update DXIL Op Defs#8163
V-FEXrt merged 1 commit intomainfrom
linalg-specs-769

Conversation

@V-FEXrt
Copy link
Collaborator

@V-FEXrt V-FEXrt commented Feb 17, 2026

microsoft/hlsl-specs#769 updated the signatures for the linalg DXIL ops. Update the implementation to reflect that

  • removes create matrix dxil op
  • renames the reserved ops to match the rest of the reserved ops
  • Update the ops to they return a matrix instead of accepting it as a parameter
  • updates the matrix type from i32 to object

utils/hct/hctdb.py is the interesting changes, everything else is generated code

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the DXIL operation definitions for linear algebra operations to align with the SM6.10 spec changes (microsoft/hlsl-specs#769). The changes modify how matrix operations handle matrix types, transitioning from i32 reference handles to proper object types and changing operations to return matrices instead of accepting them as output parameters.

Changes:

  • Removed the CreateMatrix DXIL operation (no longer needed)
  • Renamed reserved operations from LinAlgMatrixReserved* to ReservedD* for consistency
  • Updated all matrix operations to return matrix objects instead of accepting them as in/out parameters
  • Changed matrix parameter types from i32 handles to object type 'o'

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
utils/hct/hctdb.py Updated DXIL operation definitions: removed CreateMatrix, added ReservedD0, updated all matrix ops to use object types and return matrices
lib/DXIL/DxilOperations.cpp Generated code reflecting operation signature changes, overload type handling, and reserved op renaming
include/dxc/DXIL/DxilInstructions.h Generated instruction wrapper structs with updated parameter accessors and argument counts
include/dxc/DXIL/DxilConstants.h Updated OpCode enums and OpCodeClass count to reflect CreateMatrix removal and reserved op renaming
docs/DXIL.rst Updated documentation table with new operation names and descriptions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

microsoft/hlsl-specs#769 updated
the signatures for the linalg DXIL ops. Update the implementation
to reflect that
Copy link
Member

@hekota hekota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@V-FEXrt V-FEXrt merged commit e3851c5 into main Feb 18, 2026
13 checks passed
@V-FEXrt V-FEXrt deleted the linalg-specs-769 branch February 18, 2026 17:20
@github-project-automation github-project-automation bot moved this from New to Done in HLSL Roadmap Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants

Comments