Skip to content

Comments

[SPIR-V][vk::SampledTexture] #6. Add remaining .Gather...() methods for vk::SampledTexture2D type. #8149

Open
luciechoi wants to merge 6 commits intomicrosoft:mainfrom
luciechoi:gatherred
Open

[SPIR-V][vk::SampledTexture] #6. Add remaining .Gather...() methods for vk::SampledTexture2D type. #8149
luciechoi wants to merge 6 commits intomicrosoft:mainfrom
luciechoi:gatherred

Conversation

@luciechoi
Copy link
Collaborator

@luciechoi luciechoi commented Feb 10, 2026

Part of #7979

TemplateType GatherRed(float2 Location, int2 Offset1, int2 Offset2, int2 Offset3, int2 Offset4, uint Status);
TemplateType GatherGreen(float2 Location, int2 Offset1, int2 Offset2, int2 Offset3, int2 Offset4, uint Status);
TemplateType GatherBlue(float2 Location, int2 Offset1, int2 Offset2, int2 Offset3, int2 Offset4, uint Status);
TemplateType GatherAlpha(float2 Location, int2 Offset1, int2 Offset2, int2 Offset3, int2 Offset4, uint Status);
TemplateType GatherCmp(float Location, float CompareValue, int2 Offset, uint Status);
TemplateType GatherCmpRed(float Location, float CompareValue, int2 Offset1, int2 Offset2, int2 Offset3, int2 Offset4, uint Status);

GatherCmpGreen, GatherCmpBlue, GatherCmpAlpha, GatherRaw are not supported.

@luciechoi luciechoi changed the title [SPIR-V] Implement remaining Gather methods for SampledTexture. [SPIR-V] Implement remaining Gather methods for SampledTexture2D. Feb 10, 2026
@luciechoi luciechoi requested a review from s-perron February 10, 2026 18:14
Implement `GetDimensions` based on new method.
Implement  using new method
SampleCmpLevel, SampleCmpGrad, SampleCmpBias
@luciechoi luciechoi changed the title [SPIR-V] Implement remaining Gather methods for SampledTexture2D. [SPIR-V][vk::SampledTexture] #6. Add remaining .Gather...() methods for vk::SampledTexture2D type. Feb 17, 2026
Copy link
Collaborator

@Keenuts Keenuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the Gather commit (parent commit in another PR has some comments)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New

Development

Successfully merging this pull request may close these issues.

2 participants