Skip to content

chore(ci): use npm ci --ignore-scripts in Tekton install task #2710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aryamohanan wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −9
Open

chore(ci): use npm ci --ignore-scripts in Tekton install task #2710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ff679a
chore(ci): use npm ci --ignore-scripts in Tekton install task
aryamohanan Aug 12, 2026
5ba5a92
chore: updated
aryamohanan Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .tekton/tasks/install-project-dependencies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ spec:
echo "Skipping npm cache..."

echo "Installing npm dependencies..."
npm install --loglevel verbose --foreground-scripts

@aryamohanan aryamohanan Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--foreground-scripts added as part of f558acc

Since we ignore lifecycle scripts during installation, this option is no longer needed, so I removed it.

npm ci --loglevel verbose --ignore-scripts
else
echo "Restoring node_modules cache..."
curl -fsSL https://clis.cloud.ibm.com/install/linux | sh
Expand Down Expand Up @@ -100,7 +100,7 @@ spec:
echo "npm install: $npmInstall"

if [ "$npmInstall" == true ]; then
npm install --loglevel verbose --foreground-scripts
npm ci --loglevel verbose --ignore-scripts

rm -rf node-modules.tar.zst
rm -rf node-modules.tar
Expand Down Expand Up @@ -146,13 +146,13 @@ spec:
rm -rf node-modules.tar

if [ "$npmInstall" == true ]; then
npm install --loglevel verbose --foreground-scripts
npm ci --loglevel verbose --ignore-scripts
fi

echo "Restored node_modules cache..."
else
echo "Download from main was not successful. Installing node_modules..."
npm install --loglevel verbose --foreground-scripts
npm ci --loglevel verbose --ignore-scripts
fi
fi
fi
6 changes: 3 additions & 3 deletions bin/create-preinstalled-zip.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ echo "Running: 'cd $TMPDIR/package'"
cd "$TMPDIR/package"

echo "Running: 'npm install --omit=optional --omit=dev' in $TMPDIR/package"
npm install --omit=optional --omit=dev
npm install --omit=optional --omit=dev --ignore-scripts

CORE_TGZ="$TMPDIR/core.tgz"
SHARED_TGZ="$TMPDIR/shared-metrics.tgz"
Expand All @@ -75,14 +75,14 @@ else
fi

if [ ${#INSTALL_ARGS[@]} -gt 0 ]; then
echo -n "Running: npm install --omit=optional --omit=dev ${INSTALL_ARGS[@]}"
echo -n "Running: npm install --omit=optional --omit=dev --ignore-scripts ${INSTALL_ARGS[@]}"

for _p in "${INSTALL_ARGS[@]}"; do
echo -n " $_p"
done
echo

npm install --omit=optional --omit=dev "${INSTALL_ARGS[@]}"
npm install --omit=optional --omit=dev --ignore-scripts "${INSTALL_ARGS[@]}"
else
echo "No additional tgz packages to install"
fi
Expand Down
4 changes: 2 additions & 2 deletions bin/create-version-test-folders.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,8 @@ ${
} log('[INFO] Running npm install for ${suiteName}@${displayVersion}...');
const npmCmd = process.env.CI ?
'npm install --cache ${rootDir}/.npm-offline-cache --prefer-offline ' +
'${hasLockFile ? '' : '--no-package-lock '}--no-audit --prefix ./ --no-progress' :
'npm install ${hasLockFile ? '' : '--no-package-lock '}--no-audit --prefix ./ --no-progress';
'${hasLockFile ? '' : '--no-package-lock '}--no-audit --ignore-scripts --prefix ./ --no-progress' :
'npm install ${hasLockFile ? '' : '--no-package-lock '}--no-audit --ignore-scripts --prefix ./ --no-progress';

for (let attempt = 0; attempt < maxRetries; attempt++) {
const timeout = 5 * 60 * 1000;
Expand Down