chore(ci): use npm ci --ignore-scripts in Tekton install task - #2710
Open
aryamohanan wants to merge 2 commits into
Open
chore(ci): use npm ci --ignore-scripts in Tekton install task#2710aryamohanan wants to merge 2 commits into
aryamohanan wants to merge 2 commits into
Conversation
aryamohanan
commented
Aug 13, 2026
| echo "Skipping npm cache..." | ||
|
|
||
| echo "Installing npm dependencies..." | ||
| npm install --loglevel verbose --foreground-scripts |
Contributor
Author
There was a problem hiding this comment.
--foreground-scripts added as part of f558acc
Since we ignore lifecycle scripts during installation, this option is no longer needed, so I removed it.
Contributor
|
Its a great idea to reconsider this. Lets wait for the new pipes to be in place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
npm install --foreground-scriptswithnpm ci --ignore-scriptsfor dependency installs in the Tekton pipeline.npm ciinstalls strictly from package-lock.json, preventing a compromised newer version from silently resolving in--ignore-scriptsblocks preinstall/postinstall/install lifecycle hooks from running in CI, closing the exact execution vector used by the CHAINDROP/Shai-Hulud npm supply chain worm (Aug 2026)ref : https://nodejs.org/learn/getting-started/security-best-practices#supply-chain-attacks
https://www.elastic.co/security-labs/shai-hulud-chaindrop-npm-supply-chain#recommendations-how-to-respond-to-the-shai-hulud-compromise