Skip to content

test: Migrate to Vitest #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timfish wants to merge 13 commits into from
+1,224 −1,568
Closed

test: Migrate to Vitest #882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
844a6b8
test: Migrate to Vitest
timfish Feb 19, 2026
e811f67
again
timfish Feb 19, 2026
4ffc25b
we dont care about the version
timfish Feb 19, 2026
d8d0b64
more migrated
timfish Feb 24, 2026
8abf719
Merge remote-tracking branch 'upstream/main' into timfish/test/vitest
timfish Feb 24, 2026
644e5e2
Fix a couple of merge issues
timfish Feb 24, 2026
73598c3
Merge remote-tracking branch 'upstream/main' into timfish/test/vitest
timfish Feb 24, 2026
a33e6ef
Fix snapshots
timfish Feb 24, 2026
c8b43fa
Fix test
timfish Feb 24, 2026
937fe36
increase timeout for Windows
timfish Feb 24, 2026
57ec68a
Windows timeout
timfish Feb 24, 2026
748c1c2
Remove `@swc/core` dep
timfish Feb 24, 2026
a9fd966
fix snapshots
timfish Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
id: dependency-cache
with:
path: "**/node_modules"
key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
key: ${{ runner.os }}-${{ hashFiles('**/package.json') }}-${{ hashFiles('**/yarn.lock') }}
- name: Use build cache
uses: actions/cache@v4
with:
Expand Down Expand Up @@ -54,7 +54,7 @@ jobs:
id: dependency-cache
with:
path: "**/node_modules"
key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
key: ${{ runner.os }}-${{ hashFiles('**/package.json') }}-${{ hashFiles('**/yarn.lock') }}
- name: Use build cache
uses: actions/cache@v4
with:
Expand All @@ -80,7 +80,7 @@ jobs:
id: dependency-cache
with:
path: "**/node_modules"
key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
key: ${{ runner.os }}-${{ hashFiles('**/package.json') }}-${{ hashFiles('**/yarn.lock') }}
- name: Use build cache
uses: actions/cache@v4
with:
Expand All @@ -107,7 +107,7 @@ jobs:
id: dependency-cache
with:
path: "**/node_modules"
key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
key: ${{ runner.os }}-${{ hashFiles('**/package.json') }}-${{ hashFiles('**/yarn.lock') }}
- name: Use build cache
uses: actions/cache@v4
with:
Expand All @@ -131,7 +131,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: ["18", "20", "22"]
node-version: [18, 20, 22, 24]
Copy link

@cursor cursor bot Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI runs integration tests on unsupported Node 18

High Severity

The test-integration CI matrix includes Node 18 ([18, 20, 22, 24]), but packages/integration-tests/package.json now depends on "vitest": "^4.0.0", which requires Node ^20.0.0 || ^22.0.0 || >=24.0.0. Integration tests running on Node 18 in CI will fail. The PR description explicitly says integration tests are excluded from the Vitest migration to retain Node 18 support, but the migration was applied to them as well.

Additional Locations (1)

Fix in Cursor Fix in Web

Copy link
Collaborator Author

@timfish timfish Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests seem to be passing fine!

os: [ubuntu-latest, windows-latest]
runs-on: ${{ matrix.os }}
steps:
Expand All @@ -144,7 +144,7 @@ jobs:
id: dependency-cache
with:
path: "**/node_modules"
key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
key: ${{ runner.os }}-${{ hashFiles('**/package.json') }}-${{ hashFiles('**/yarn.lock') }}
- name: Use build cache
uses: actions/cache@v4
with:
Expand Down Expand Up @@ -182,7 +182,7 @@ jobs:
id: dependency-cache
with:
path: "**/node_modules"
key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
key: ${{ runner.os }}-${{ hashFiles('**/package.json') }}-${{ hashFiles('**/yarn.lock') }}
- name: Use build cache
uses: actions/cache@v4
with:
Expand Down Expand Up @@ -214,7 +214,7 @@ jobs:
id: dependency-cache
with:
path: "**/node_modules"
key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
key: ${{ runner.os }}-${{ hashFiles('**/package.json') }}-${{ hashFiles('**/yarn.lock') }}
- name: Use build cache
uses: actions/cache@v4
with:
Expand Down
11 changes: 2 additions & 9 deletions packages/babel-plugin-component-annotate/.eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
const jestPackageJson = require("jest/package.json");

/** @type {import('eslint').ESLint.Options} */
module.exports = {
root: true,
extends: ["@sentry-internal/eslint-config/jest", "@sentry-internal/eslint-config/base"],
ignorePatterns: [".eslintrc.js", "dist", "jest.config.js", "rollup.config.mjs"],
extends: ["@sentry-internal/eslint-config/base"],
ignorePatterns: [".eslintrc.js", "dist", "rollup.config.mjs"],
parserOptions: {
tsconfigRootDir: __dirname,
project: ["./src/tsconfig.json", "./test/tsconfig.json"],
Expand All @@ -15,9 +13,4 @@ module.exports = {
env: {
node: true,
},
settings: {
jest: {
version: jestPackageJson.version,
},
},
};
6 changes: 0 additions & 6 deletions packages/babel-plugin-component-annotate/jest.config.js
View file
Open in desktop

This file was deleted.

7 changes: 2 additions & 5 deletions packages/babel-plugin-component-annotate/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,21 +46,18 @@
"clean:all": "run-p clean clean:deps",
"clean:build": "premove ./dist *.tgz",
"clean:deps": "premove node_modules",
"test": "jest",
"test": "vitest run",
"lint": "eslint ./src ./test"
},
"devDependencies": {
"@babel/core": "7.18.5",
"@babel/preset-react": "^7.23.3",
"@sentry-internal/eslint-config": "5.1.0",
"@sentry-internal/sentry-bundler-plugin-tsconfig": "5.1.0",
"@swc/core": "^1.2.205",
"@swc/jest": "^0.2.21",
"@types/jest": "^28.1.3",
"@types/node": "^18.6.3",
"@types/uuid": "^9.0.1",
"eslint": "^8.18.0",
"jest": "^28.1.1",
"vitest": "^4.0.0",
"premove": "^4.0.0",
"rolldown": "^1.0.0-rc.4",
"ts-node": "^10.9.1",
Expand Down
372 changes: 186 additions & 186 deletions packages/babel-plugin-component-annotate/test/__snapshots__/test-plugin.test.ts.snap
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading