Conversation
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
951a498 to
abbdcc7
Compare
b215b75 to
844a6b8
Compare
packages/integration-tests/fixtures/component-name-annotate/component-name-annotate.test.ts
Show resolved
Hide resolved
packages/integration-tests/fixtures/errorhandling/error-no-handler.test.ts
Outdated
Show resolved
Hide resolved
...s/integration-tests/fixtures/build-information-injection/build-information-injection.test.ts
Outdated
Show resolved
Hide resolved
55800f6 to
00a9df5
Compare
00a9df5 to
644e5e2
Compare
packages/rollup-plugin/test/__snapshots__/public-api.test.ts.snap
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| fail-fast: false | ||
| matrix: | ||
| node-version: ["18", "20", "22"] | ||
| node-version: [18, 20, 22, 24] |
There was a problem hiding this comment.
CI runs integration tests on unsupported Node 18
High Severity
The test-integration CI matrix includes Node 18 ([18, 20, 22, 24]), but packages/integration-tests/package.json now depends on "vitest": "^4.0.0", which requires Node ^20.0.0 || ^22.0.0 || >=24.0.0. Integration tests running on Node 18 in CI will fail. The PR description explicitly says integration tests are excluded from the Vitest migration to retain Node 18 support, but the migration was applied to them as well.
Additional Locations (1)
There was a problem hiding this comment.
The tests seem to be passing fine!
chargome
left a comment
There was a problem hiding this comment.
Looks good! Just double checking: in the descr you mentioned migrating to vitest apart from the integration tests but this pr does migrate them right?
|
Ah yes, I'll update that! Just realised this PR doesn't update the e2e snapshots and these didn't run and fail in CI because it's from a fork. |


This PR:
package.jsonresulted in no lock change and a build failureas unknown as vite.Pluginbecause the Vite versions varied between the plugin and integration tests. This does not impact end users because it will use their Vite version.