[quick_actions] Adopt code-excerpts for README - #12643
Draft
danielleon-cmd wants to merge 5 commits into
Draft
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
16 tasks
danielleon-cmd
force-pushed
the
fpoctsmp-10-quick-actions-readme-excerpts
branch
from
August 27, 2026 15:55
8ec30ab to
bf1351c
Compare
Replaces the hand-written Dart snippets in the README with <?code-excerpt?> pragmas backed by example/lib/readme_excerpts.dart, so they're validated against compilable, analyzed source instead of being free-hand text (one used an untyped callback parameter and print(), which isn't allowed by the repo's lint rules). Also drops the package's ci_config.yaml, whose only purpose was opting it out of that validation. Part of flutter/flutter#102679. FPOCTSMP-10
danielleon-cmd
force-pushed
the
fpoctsmp-10-quick-actions-readme-excerpts
branch
from
August 27, 2026 16:08
bf1351c to
729590c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the hand-written Dart snippets in
quick_actions's README with<?code-excerpt?>pragmas backed byexample/lib/readme_excerpts.dart, so they're validated against compilable, analyzed source instead of free-hand text (the original used an untyped callback parameter andprint(), which the repo's lint rules disallow). Also drops the package'sci_config.yaml, whose only purpose was opting it out of that validation.Follows the same pattern as #12641 ([pointer_interceptor] Adopt code-excerpts for README).
Part of #102679.
Pre-Review Checklist
[shared_preferences]1.1.1).///). — not applicable, no public API surface changed.readme_excerpts.dartis validated bydart analyze/dart formatand theupdate-excerptscheck itself; no runtime behavior changed.Test plan
dart run script/tool/bin/flutter_plugin_tools.dart update-excerpts --packages=quick_actions— no diff after regenerationdart run script/tool/bin/flutter_plugin_tools.dart validate --packages=quick_actions— no issuesflutter analyzeinexample/— no issuesdart format --output=none --set-exit-if-changedon the new excerpts file — no changes neededflutter testin the package — all tests passNote: The Flutter team is currently trialing Gemini Code Assist for GitHub. Comments from
gemini-code-assist[bot]aren't authoritative Flutter-team feedback; I'll wait for a human reviewer's guidance on which automated comments (if any) should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩