[espresso] Adopt code-excerpts for README - #12644
Draft
danielleon-cmd wants to merge 5 commits into
Draft
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
danielleon-cmd
force-pushed
the
fpoctsmp-5-espresso-readme-excerpts
branch
from
August 27, 2026 15:56
f6608a0 to
09d6734
Compare
The excerpt validator only requires code-excerpt management for Dart code blocks, so the README's Java/Groovy/XML/sh snippets are untouched. The one Dart block (the test_driver script) used the deprecated flutter_driver enableFlutterDriverExtension() API, which no longer has a real, compilable counterpart in this repo now that the example app migrated to the integration_test package. Points the excerpt at the example's actual test_driver/integration_test.dart (integrationDriver()) instead, and updates the surrounding prose and gradle command to match. Also drops the package's ci_config.yaml, whose only purpose was opting it out of that validation. Part of flutter/flutter#102679. FPOCTSMP-5
danielleon-cmd
force-pushed
the
fpoctsmp-5-espresso-readme-excerpts
branch
from
August 27, 2026 16:09
66ab473 to
36c41c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The excerpt validator (
readme_validator.dart) only requires<?code-excerpt?>management for Dart code blocks, so the README's Java/Groovy/XML/sh snippets are left untouched. The one Dart block — thetest_driver/script — used the deprecatedflutter_driverenableFlutterDriverExtension()API, which no longer has a real, compilable counterpart in this repo now that the example app migrated to theintegration_testpackage. Points the excerpt at the example's actualtest_driver/integration_test.dart(integrationDriver()) instead, and updates the surrounding prose and the./gradlewcommand to match the real filename. Also drops the package'sci_config.yaml, whose only purpose was opting it out of that validation.Follows the same pattern as #12641 ([pointer_interceptor] Adopt code-excerpts for README) and #12643 ([quick_actions] Adopt code-excerpts for README).
Part of #102679.
Pre-Review Checklist
[shared_preferences]0.4.0+26).///). — not applicable, no public API surface changed.test_driver/integration_test.dartdocregion is validated bydart analyze/dart formatand theupdate-excerptscheck itself; no runtime behavior changed.Test plan
dart run script/tool/bin/flutter_plugin_tools.dart update-excerpts --packages=espresso— no diff after regenerationdart run script/tool/bin/flutter_plugin_tools.dart validate --packages=espresso— no issuesflutter analyzeinexample/— no issuesdart format --output=none --set-exit-if-changedon the updated driver file — no changes neededNote: The Flutter team is currently trialing Gemini Code Assist for GitHub. Comments from
gemini-code-assist[bot]aren't authoritative Flutter-team feedback; I'll wait for a human reviewer's guidance on which automated comments (if any) should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩