Should Move project to 160 of 160 points - uses simple_chat as project example.#629
Should Move project to 160 of 160 points - uses simple_chat as project example.#629hunterino wants to merge 5 commits intoflutter:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request significantly improves the project's structure and documentation. Moving the simple_chat example to the standard example/ directory is a great change that follows Dart conventions. The added documentation in the core genui classes and the new examples/examples.md overview are also valuable additions.
One suggestion is to rename example/example.md to example/README.md to follow standard project structure and improve discoverability on platforms like GitHub.
I've added one specific comment on the newly added examples.md file.
jacobsimionato
left a comment
There was a problem hiding this comment.
Thanks so much for this cleanup!
We would prefer to keep all the examples together in a folder.
What if you keep simple_chat where it is, but then rename examples to example, and add the readme that you already created at example/README.md. I'm not 100%, but based on https://dart.dev/tools/pub/package-layout#examples, I suspect this will create the example tab in the UI and hopefully give us the 10 points :-D.
Description
PR for issues 628
Pre-launch Checklist
///).