Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request adds README files to improve documentation and the package's pub score. The new examples/README.md provides a great overview of the example applications. I've found a couple of issues in the run commands for the verdure example that need correction. I also noticed an incomplete entry in the CHANGELOG.md. My detailed comments are below.
|
@hunterino I think the way I attributed you in this PR ( |
Co-Authored-By: hunterino <mhunter@hunter.org>
|
I think it's easier if I tweak @hunterino's PR, instead of attempt to create a new one (~_~) |
Description
This PR adds a couple of README files to:
package:genuiin pub to 160.examplesdirectory in the monorepo (taken from @hunterino's PR: Should Move project to 160 of 160 points - uses simple_chat as project example. #629)Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.