Skip to content

Playwright common: ignore $DOCKER_HOST check on macos #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
florianduros wants to merge 1 commit into from
Closed

Playwright common: ignore $DOCKER_HOST check on macos #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 19 additions & 13 deletions packages/element-web-playwright-common/playwright-screenshots.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ SCRIPT_DIR=$(dirname "$SCRIPT_PATH")
IMAGE_NAME="element-web-playwright-common"

if docker --version | grep -q podman; then docker_is_podman=1; fi
if [[ "$OSTYPE" == "darwin"* ]]; then os_is_macos=true; fi

build_image() {
echo "Building $IMAGE_NAME image in $SCRIPT_DIR"
Expand All @@ -21,19 +22,24 @@ build_image() {
docker build -t "$IMAGE_NAME" --build-arg "PLAYWRIGHT_VERSION=$PW_VERSION" "$SCRIPT_DIR"
}

# Find the docker socket on the host
case "$DOCKER_HOST" in
unix://*)
docker_sock="${DOCKER_HOST:7}"
;;
"")
docker_sock="/var/run/docker.sock"
;;
*)
echo "$0: unsupported DOCKER_HOST setting '${DOCKER_HOST}'" >&2
exit 1;
;;
esac
# Docker is running in a VM on macOS, the socket location is at his default location
if [ "$os_is_macos" = true ]; then
docker_sock="/var/run/docker.sock"
else
# Find the docker socket on the host
case "$DOCKER_HOST" in
unix://*)
docker_sock="${DOCKER_HOST:7}"
;;
"")
docker_sock="/var/run/docker.sock"
;;
*)
echo "$0: unsupported DOCKER_HOST setting '${DOCKER_HOST}'" >&2
exit 1;
;;
esac
fi

RUN_ARGS=(
--rm
Expand Down