Playwright common: ignore $DOCKER_HOST check on macos#191
Draft
florianduros wants to merge 1 commit intomainfrom
Draft
Playwright common: ignore $DOCKER_HOST check on macos#191florianduros wants to merge 1 commit intomainfrom
florianduros wants to merge 1 commit intomainfrom
Conversation
florianduros
changed the title
t3chguy
reviewed
Feb 4, 2026
Member
t3chguy
left a comment
t3chguy
left a comment
There was a problem hiding this comment.
I don't think this is valid, some docker environments e.g. rootless podman may use a different path.
Member
Author
|
Hmm so only colima on macos? |
Member
|
Probably also only certain configurations of Colima, @sandhose said his docker socket path is not the one you assume it is, even on Colima. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Playright common: ignore $DOCKER_HOST check on macos