-
Notifications
You must be signed in to change notification settings - Fork 33
feat: link primary bundle Needs to Bazel targets #854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
a-zw
merged 7 commits into
eclipse-score:main
from
etas-contrib:feature/bundle-needs-metadata
Sep 25, 2026
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
64d1793
feat: attach bundle targets to Needs
AlexanderLanin 37558e5
test: cover multiple bundle targets
AlexanderLanin d738ce4
test: update bundle metadata golden samples
AlexanderLanin 2bcc1b1
refactor: clarify bundle target value encoding
AlexanderLanin 0eafa63
test: cover external bundle metadata
AlexanderLanin 88765ce
feat: use explicit primary Need for bundle metadata
AlexanderLanin cc88e8c
Use None for public primary need ID default
AlexanderLanin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -226,6 +226,7 @@ def _declare_docs_bundle( | |
| entry_doc = "index", | ||
| bundles = [], | ||
| code_targets = [], | ||
| primary_need_id = None, | ||
| visibility = None, | ||
| **kwargs): | ||
| """Declare the shared bundle target implementation. | ||
|
|
@@ -263,6 +264,9 @@ def _declare_docs_bundle( | |
| code_targets: Implementation targets or filegroups to scan for source-code | ||
| links. Implementation target source files and their dependencies | ||
| are collected recursively; filegroups expand to their files. | ||
| primary_need_id: Sphinx-Needs ID of the primary Need representing this | ||
| bundle. Other Needs may remain in the bundle; only this | ||
| Need receives bundle-level target metadata. | ||
| visibility: Target visibility. | ||
| **kwargs: Additional attributes forwarded to the underlying rule. | ||
| """ | ||
|
|
@@ -305,6 +309,7 @@ def _declare_docs_bundle( | |
| bundles = bundles, | ||
| data = bundle_data, | ||
| code_targets = code_targets, | ||
| primary_need_id = primary_need_id, | ||
| visibility = visibility, | ||
| **kwargs | ||
| ) | ||
|
|
@@ -398,6 +403,7 @@ def docs_bundle( | |
| entry_doc = "index", | ||
| bundles = [], | ||
| code_targets = [], | ||
| primary_need_id = None, | ||
| visibility = None, | ||
| **kwargs): | ||
| """Declare a reusable documentation bundle. | ||
|
|
@@ -415,6 +421,7 @@ def docs_bundle( | |
| entry_doc = entry_doc, | ||
| bundles = bundles, | ||
| code_targets = code_targets, | ||
| primary_need_id = primary_need_id, | ||
| visibility = visibility, | ||
| **kwargs | ||
| ) | ||
|
|
@@ -500,6 +507,7 @@ def docs( | |
| deps = [], | ||
| external_needs = [], | ||
| code_targets = [], | ||
| primary_need_id = None, | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if people are using positional parameters they deserve trouble |
||
| test_sources = [], | ||
| known_good = None, | ||
| metamodel = None, | ||
|
|
@@ -523,6 +531,9 @@ def docs( | |
| code_targets: Implementation targets or filegroups to scan for source code | ||
| links. Implementation targets are scanned recursively; filegroups | ||
| expand to their files. | ||
| primary_need_id: Sphinx-Needs ID of the primary Need representing this | ||
| documentation project and its root bundle. Other Needs | ||
| remain unchanged. | ||
| test_sources: Optional list of repo-relative directory paths which will be used to filter testcases for documentation generation. | ||
| When empty (default), all testcases found in `bazel-testlogs` will be used. | ||
| known_good: Optional label to a "known good" JSON file for source links. | ||
|
|
@@ -586,6 +597,7 @@ def docs( | |
| entry_doc = "index", | ||
| bundles = bundles, | ||
| code_targets = code_targets, | ||
| primary_need_id = primary_need_id, | ||
| visibility = ["//visibility:public"], | ||
| tags = ["manual"] | ||
| ) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if people are using positional parameters they deserve trouble