feat: link primary bundle Needs to Bazel targets - #854
Conversation
AlexanderLanin
changed the title
|
Documentation preview for this pull request is available at: |
MaximilianSoerenPollak
left a comment
MaximilianSoerenPollak
left a comment
There was a problem hiding this comment.
This looks good imo, but I have some questions regarding some of the details etc.
AlexanderLanin
changed the title
MaximilianSoerenPollak
left a comment
MaximilianSoerenPollak
left a comment
There was a problem hiding this comment.
Now with the primary need idea looks much better for sure concept wise.
Still one questions but those cna be addressed in future PR's.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Public macro positional compatibility is broken, and custom metamodels do not register the generated fields.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 3
Open (3)
| entry_doc = "index", | ||
| bundles = [], | ||
| code_targets = [], | ||
| primary_need_id = None, |
There was a problem hiding this comment.
if people are using positional parameters they deserve trouble
| deps = [], | ||
| external_needs = [], | ||
| code_targets = [], | ||
| primary_need_id = None, |
There was a problem hiding this comment.
if people are using positional parameters they deserve trouble
| bazel_target: ^.*$ | ||
| bazel_type: ^.*$ |
There was a problem hiding this comment.
yeah open point for any such type
MaximilianSoerenPollak
left a comment
MaximilianSoerenPollak
left a comment
There was a problem hiding this comment.
Fine from my side now. ✅
Why
When users inspect the generated Needs for a documentation bundle, they should be able to see which Bazel target provides the implementation behind the bundle's main subject. This makes the path from a feature or component Need to its implementation easier to understand and gives downstream tools reliable build metadata for traceability and navigation.
A bundle may contain many Needs, such as a feature and its individual requirements. The bundle therefore declares which Need is its primary subject. The generated metadata is attached to that Need, independently of the names of the bundle, target, or child Needs.
What changed
primary_need_idtodocs_bundle()anddocs().