Improve server initialization and error handling#8982
Merged
dibarbet merged 3 commits intodotnet:mainfrom Feb 18, 2026
Merged
Conversation
b660f86 to
937e211
Compare
937e211 to
5d50a4c
Compare
JoeRobich
reviewed
Feb 12, 2026
| return args; | ||
| } | ||
|
|
||
| private static async getCSharpDevkitIntelliCodeExportArgs( |
JoeRobich
approved these changes
Feb 12, 2026
dibarbet
added a commit
to dotnet/roslyn
that referenced
this pull request
Feb 17, 2026
…82376) This has a few miscellaneous changes to improve process lifecycle stuff. 1. Update the support for named pipe as a process argument (LSP spec details - https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#implementationConsiderations) to work better with the VSCode client 2. Ensure service broker bridge cancels properly if we need to stop the process on our side to prevent lingering processes 3. Ensure the process reports errors when we encounter an exception in the LSP queue that takes down the server. Previously the process would cleanly exit even if we decided to shutdown due to an issue in the LSP queue loop. Needs to be paired with dotnet/vscode-csharp#8982
5d50a4c to
a70fe70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paired with dotnet/roslyn#82376
This came up as part of the overall C#DK reliability effort. Currently the experience in the editor when the language server fails isn't great. A couple issues:
This PR does a few things