Simplify LSP server initialization and improve failure experience

Author: dibarbet

l10n/bundle.l10n.json

@@ -157,9 +157,6 @@
   "Do not load any": "Do not load any",
   "Reload C# Extension": "Reload C# Extension",
   "Detected change in telemetry settings. These will not take effect until the language server is restarted, would you like to restart?": "Detected change in telemetry settings. These will not take effect until the language server is restarted, would you like to restart?",
-  "IntelliCode features will not be available, {0} failed to activate.": "IntelliCode features will not be available, {0} failed to activate.",
-  "Go to output": "Go to output",
-  "Suppress notification": "Suppress notification",
   "Restore {0}": "Restore {0}",
   "Restore already in progress": "Restore already in progress",
   "Select context": "Select context",

src/lsptoolshost/server/roslynLanguageClient.ts

@@ -3,13 +3,15 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
+import * as vscode from 'vscode';
 import { CancellationToken, MessageSignature } from 'vscode-jsonrpc';
-import { LanguageClient } from 'vscode-languageclient/node';
-import { LanguageClientOptions, ServerOptions } from 'vscode-languageclient';
+import { LanguageClient, ServerOptions } from 'vscode-languageclient/node';
+import { LanguageClientOptions } from 'vscode-languageclient';
 import CompositeDisposable from '../../compositeDisposable';
 import { IDisposable } from '../../disposable';
 import { languageServerOptions } from '../../shared/options';
 import { RoslynLspErrorCodes } from './roslynProtocol';
+import { showErrorMessageWithOptions } from '../../shared/observers/utils/showMessage';
 
 /**
  * Implementation of the base LanguageClient type that allows for additional items to be disposed of
@@ -57,7 +59,32 @@ export class RoslynLanguageClient extends LanguageClient {
         if (languageServerOptions.suppressLspErrorToasts) {
             return super.handleFailedRequest(type, token, error, defaultValue, false);
         }
-        return super.handleFailedRequest(type, token, error, defaultValue, showNotification);
+        // test.
+        // todo - we need to somehow prevent this from showing toasts for errors when the server crashes, since we already get them below too.
+        return super.handleFailedRequest(type, token, error, defaultValue, false);
+    }
+
+    override error(message: string, data?: any, showNotification?: boolean | 'force'): void {
+        // Show custom error toast with report issue command button, the base does not include this.
+        // Here we only show toasts for critical errors (when showNotification is 'force').
+
+        // todo - this needs to de-duplicate errors.  on crashes we can get multiple errors (slightly diff messages, esp if stopping the server failed).
+        // @ts-expect-error dddddd
+        const s = this.state;
+        if (showNotification === 'force') {
+            showErrorMessageWithOptions(
+                vscode,
+                message,
+                { modal: false },
+                {
+                    title: 'Report Issue',
+                    command: 'csharp.reportIssue',
+                }
+            );
+            showNotification = false; // prevent the base class from showing another toast with the same message.
+        }
+
+        super.error(message, data, showNotification);
     }
 
     /**