Skip to content

Set DOTNET_EnableDumpOnSigTerm when crash dumps are enabled #8980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
333fred wants to merge 1 commit into from
Closed

Set DOTNET_EnableDumpOnSigTerm when crash dumps are enabled #8980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/lsptoolshost/dotnetRuntime/dotnetRuntimeExtensionResolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ export class DotnetRuntimeExtensionResolver implements IHostExecutableResolver {
env.DOTNET_DbgMiniDumpType = '4';
// Collect crashreport.json with additional thread and stack frame information.
env.DOTNET_EnableCrashReport = '1';
// Collect dumps when the process is sent a SigTerm as well
env.DOTNET_EnableDumpOnSigTerm = '1';
Copy link
Copy Markdown
Member

@dibarbet dibarbet Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly worried we might get a ton of useless dumps - like for example if vscode is shutting down and kills the process. Can we check if that happens?

Copy link
Copy Markdown
Member

@dibarbet dibarbet Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To some extent it might be reasonable in that the user has already set the crashdump path. But it would be pretty bad if they leave it on and fill up their machine with useless dumps that aren't real crashes.

Copy link
Copy Markdown
Member

@JoeRobich JoeRobich Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have the user set this on an as needed basis using the new env args setting?

// The dump file name format is <executable>.<pid>.dmp
env.DOTNET_DbgMiniDumpName = path.join(languageServerOptions.crashDumpPath, '%e.%p.dmp');
}
Expand Down
Loading