Set DOTNET_EnableDumpOnSigTerm when crash dumps are enabled#8980
Open
333fred wants to merge 1 commit intodotnet:mainfrom
Open
Set DOTNET_EnableDumpOnSigTerm when crash dumps are enabled#8980333fred wants to merge 1 commit intodotnet:mainfrom
333fred wants to merge 1 commit intodotnet:mainfrom
Conversation
This will ensure that when the OS sends the language server a sigterm, we also get a dump of that.
Member
Author
|
The main thing I'm concerned about here is whether this will be "too" verbose, creating dumps for otherwise ok scenarios. @dibarbet @JoeRobich for thoughts. |
dibarbet
reviewed
Feb 10, 2026
| // Collect crashreport.json with additional thread and stack frame information. | ||
| env.DOTNET_EnableCrashReport = '1'; | ||
| // Collect dumps when the process is sent a SigTerm as well | ||
| env.DOTNET_EnableDumpOnSigTerm = '1'; |
Member
There was a problem hiding this comment.
Slightly worried we might get a ton of useless dumps - like for example if vscode is shutting down and kills the process. Can we check if that happens?
Member
There was a problem hiding this comment.
To some extent it might be reasonable in that the user has already set the crashdump path. But it would be pretty bad if they leave it on and fill up their machine with useless dumps that aren't real crashes.
Member
There was a problem hiding this comment.
Can we have the user set this on an as needed basis using the new env args setting?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will ensure that when the OS sends the language server a sigterm, we also get a dump of that.