Add Azure auth sample app - review feedback fixes#4027
Closed
Copilot wants to merge 2 commits intodev/paul/azure-samplesfrom
Closed
Add Azure auth sample app - review feedback fixes#4027Copilot wants to merge 2 commits intodev/paul/azure-samplesfrom
Copilot wants to merge 2 commits intodev/paul/azure-samplesfrom
Conversation
Co-authored-by: paulmedynski <31868385+paulmedynski@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add Azure auth sample app
Add Azure auth sample app - review feedback fixes
Mar 10, 2026
Contributor
|
This isn't what I asked for. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses unresolved review comments from the second review pass on the AzureAuthentication sample app.
Description
Bug fixes
EndProjectafter theAzureAuthenticationproject entry — the omission made the.slnstructurally invalidpackages/.gitkeep: Fixed grammar typo ("This presence" → "The presence")Code hygiene
EntryPoint.cs:SetActionlambda was returningint, which doesn't matchAction<ParseResult>. Capture exit code via closure instead:App.cs: Replaced heavyweight AKV provider instantiation (which required aDefaultAzureCredential) with a lightweight assembly-load check:App.cs: Removed verbose full connection string output — printingSqlConnectionStringBuilder.ToString()could leak passwords and access tokensApp.cs/SqlClientEventListener.cs: Definedinternal const string Prefix = "[EVENT]"onSqlClientEventListenerand replaced the hardcoded literal inApp.csApp.cs: Removedusing Azure.Identity— no longer referenced after the AKV check simplificationDocumentation
README.md: Synced the defaults table withDirectory.Packages.props(6.1.x→7.0.0-preview*); fixed pre-release version format in help output example (7.0.0.preview4→7.0.0-preview4)Issues
Testing
Sample app only — no automated tests. Changes are structural/correctness fixes with no runtime behavior change except removal of the verbose connection string output.
Guidelines
Please review the contribution guidelines before submitting a pull request:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.