Conversation
…ork together to provide EntraID authentication functionality.
paulmedynski
added
Area\Tests
There was a problem hiding this comment.
Pull request overview
This PR adds a new sample console application for testing Azure authentication with Microsoft.Data.SqlClient. The app is designed as a smoke test to verify package compatibility and Azure AD authentication functionality, with support for testing against both published NuGet packages and locally-built packages from the packages/ directory.
Changes:
- Adds
AzureAuthenticationsample app indoc/apps/AzureAuthentication/with flexible package version configuration - Includes comprehensive documentation with usage examples and build instructions
- Updates
doc/Directory.Packages.propsto reference the latest stable SqlClient version (6.1.4)
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
src/Microsoft.Data.SqlClient.sln |
Adds the new AzureAuthentication project to the solution |
doc/apps/AzureAuthentication/AzureAuthentication.csproj |
Project file targeting net481 and net10.0 with conditional Azure package references |
doc/apps/AzureAuthentication/Program.cs |
Main application implementing command-line interface with connection testing and event logging |
doc/apps/AzureAuthentication/README.md |
Comprehensive documentation covering purpose, usage, examples, and prerequisites |
doc/apps/AzureAuthentication/Directory.Build.props |
Enables Central Package Management for the sample app |
doc/apps/AzureAuthentication/Directory.Packages.props |
Defines default package versions with overridable MSBuild properties |
doc/apps/AzureAuthentication/NuGet.config |
Configures local packages/ directory as a package source |
doc/apps/AzureAuthentication/GeneratePackageVersions.targets |
MSBuild task to generate code exposing package versions at runtime |
doc/apps/AzureAuthentication/packages/.gitkeep |
Ensures git tracks the empty packages directory |
doc/Directory.Packages.props |
Updates SqlClient reference to latest stable version 6.1.4 |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #3988 +/- ##
==========================================
- Coverage 72.65% 64.97% -7.68%
==========================================
Files 287 282 -5
Lines 43134 66043 +22909
==========================================
+ Hits 31337 42913 +11576
- Misses 11797 23130 +11333
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.
You can also share your feedback on Copilot code review. Take the survey.
|
@copilot open a new pull request to apply changes based on the comments in this thread. Do not consider outdated comments. |
|
@paulmedynski I've opened a new pull request, #4027, to work on those changes. Once the pull request is ready, I'll request review from you. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
You can also share your feedback on Copilot code review. Take the survey.
@mdaigle A bit of both. I'll use it myself for 7.0 GA validation, and then point to it in the reference docs as appropriate. |
There was a problem hiding this comment.
Could this be also consumed by the doc\samples project? I would recommend making Samples and Apps have similar build experiences.
There was a problem hiding this comment.
Let's consider this as part of the ongoing Samples work. I'm not sure samples need to use unpublished packages, but maybe they will in the future.
Description
Adds a sample app for testing Azure authentication with flexibility to supply published and local SqlClient packages.