Skip to content

fix: include furniture field in DoclingDocument #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mohammedfaisal wants to merge 1 commit into
base: main
Choose a base branch
from
+54 −0
Open

fix: include furniture field in DoclingDocument #387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docling-core/src/main/java/ai/docling/core/DoclingDocument.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ public class DoclingDocument {
@JsonProperty("body")
private GroupItem body;

@JsonProperty("furniture")
@Nullable
private GroupItem furniture;

@JsonProperty("groups")
@JsonSetter(nulls = Nulls.AS_EMPTY)
@lombok.Singular
Expand Down
50 changes: 50 additions & 0 deletions docling-core/src/test/java/ai/docling/core/DoclingDocumentTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,12 @@

import org.junit.jupiter.api.Test;

import com.fasterxml.jackson.databind.ObjectMapper;

import ai.docling.core.DoclingDocument.ContentLayer;
import ai.docling.core.DoclingDocument.DocItemLabel;
import ai.docling.core.DoclingDocument.GroupItem;
import ai.docling.core.DoclingDocument.GroupLabel;
import ai.docling.core.DoclingDocument.TitleItem;

/**
Expand Down Expand Up @@ -35,4 +40,49 @@ void shouldBuildDocumentWithProperties() {
assertThat(titleItem.getText()).isEqualTo("Docling Rocks!");
}

@Test
void shouldSerializeFurnitureField() throws Exception {
ObjectMapper mapper = new ObjectMapper();
GroupItem furniture = GroupItem.builder()
.selfRef("#/furniture")
.contentLayer(ContentLayer.FURNITURE)
.label(GroupLabel.UNSPECIFIED)
.name("_root_")
.build();

DoclingDocument document = DoclingDocument.builder()
.name("test-document")
.furniture(furniture)
.build();

String json = mapper.writeValueAsString(document);

assertThat(json).contains("\"furniture\"");
assertThat(json).contains("\"content_layer\":\"furniture\"");
}

@Test
void shouldDeserializeFurnitureField() throws Exception {
ObjectMapper mapper = new ObjectMapper();
String json = """
{
"name": "test-document",
"furniture": {
"self_ref": "#/furniture",
"children": [],
"content_layer": "furniture",
"name": "_root_",
"label": "unspecified"
}
}
""";

DoclingDocument document = mapper.readValue(json, DoclingDocument.class);

assertThat(document.getFurniture()).isNotNull();
assertThat(document.getFurniture().getSelfRef()).isEqualTo("#/furniture");
assertThat(document.getFurniture().getContentLayer()).isEqualTo(ContentLayer.FURNITURE);
assertThat(document.getFurniture().getLabel()).isEqualTo(GroupLabel.UNSPECIFIED);
}

}