fix: include furniture field in DoclingDocument#387
Open
mohammedfaisal wants to merge 1 commit intodocling-project:mainfrom
Open
fix: include furniture field in DoclingDocument#387mohammedfaisal wants to merge 1 commit intodocling-project:mainfrom
mohammedfaisal wants to merge 1 commit intodocling-project:mainfrom
Conversation
oscerd
approved these changes
Mar 6, 2026
edeandrea
changed the title
Contributor
|
Thanks for this @mohammedfaisal ! Could you please fix the DCO (i.e. you probably did not sign your commit) & amend your commit so it passes the Semantic PR spec? |
Contributor
|
Also, could you please add something to the existing test cases for this field? |
:java_duke: JaCoCo coverage report
|
|
||||||||||||||
|
HTML test reports are available as workflow artifacts (zipped HTML). • Download: Artifacts for this run |
mohammedfaisal
force-pushed
the
fix/furniture-field-missing-in-docling-document
branch
from
eafebb4 to
1b6d051
Compare
Author
|
Hi @edeandrea I've fixed the DCO, updated the commit message to follow the Semantic PR spec, and added test cases for the furniture field. Please take a look when you get a chance. |
Fixes docling-project#386 Signed-off-by: Mohammed Faisal <mohammedfaisal@users.noreply.github.com>
mohammedfaisal
force-pushed
the
fix/furniture-field-missing-in-docling-document
branch
from
1b6d051 to
7bcebc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #386:
furnituretoDoclingDocument.java